Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dual-stack]support service ipFamilies update event in service controller #116495

Closed
BraceCY opened this issue Mar 11, 2023 · 2 comments · Fixed by #116520
Closed

[dual-stack]support service ipFamilies update event in service controller #116495

BraceCY opened this issue Mar 11, 2023 · 2 comments · Fixed by #116520
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@BraceCY
Copy link

BraceCY commented Mar 11, 2023

What would you like to be added?

Currently, when loadbalancer service's ipFammilies updated,service controller will ignore this event. That means cloud provider can't update ipv4/ipv6 backend.
So, I'm thinking service controller need add watching 'service's ipFammilies updated' event, It'd be important for cloud provider update dual-stack backend.

code at :https://github.com/kubernetes/cloud-provider/blob/fa271f103b481b342ed5eefd9cde68c30bf3b114/controllers/service/controller.go#L526

Why is this needed?

Our load balancer supports dual-stack. When the services in the cluster are updated from IPv4 to IPv6(same ipv6->ipv4、ipv4->ipv4/ipv6), it is expected that the cloud provider can perceive this event and update the IPv4/IPv6 address to the backend of the load balancer.

/sig cloud-provider
/area cloudprovider

@BraceCY BraceCY added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 11, 2023
@aojea
Copy link
Member

aojea commented Mar 11, 2023

yeah, that is right, the logic need to be adapted

/kind bug
/sig network
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2023
@thockin thockin added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants