Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet dra: add lock to addCDIDevices #116621

Merged
merged 1 commit into from Mar 15, 2023
Merged

kubelet dra: add lock to addCDIDevices #116621

merged 1 commit into from Mar 15, 2023

Conversation

moshe010
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @moshe010. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2023
@ffromani
Copy link
Contributor

/ok-to-test
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
klueska
klueska reviewed Mar 14, 2023
View reviewed changes
pkg/kubelet/cm/dra/claiminfo.go

func (info *ClaimInfo) addCDIDevices(pluginName string, cdiDevices []string) error {
info.Lock()
defer info.Unlock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, put a newline after this.

@ffromani
Copy link
Contributor

@klueska @moshe010 any more context about this PR?

@klueska
Copy link
Contributor

klueska commented Mar 14, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2023
@ffromani
Copy link
Contributor

/priority important-soon

considering the recent activity in this area and the nature of the PR

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 14, 2023
@moshe010
kubelet dra: add lock to addCDIDevices
ffb07d1 
Signed-off-by: Moshe Levi <moshele@nvidia.com>
@klueska
Copy link
Contributor

klueska commented Mar 14, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54659e7575dcf0dceaadb3a45177b832f91a5025

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, moshe010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@klueska
Copy link
Contributor

klueska commented Mar 14, 2023

/retest

1 similar comment
@klueska
Copy link
Contributor

klueska commented Mar 14, 2023

/retest

@cici37 cici37 added this to the v1.27 milestone Mar 15, 2023
bart0sh
bart0sh reviewed Mar 15, 2023
View reviewed changes
pkg/kubelet/cm/dra/claiminfo.go
if info.CDIDevices == nil {
info.CDIDevices = make(map[string][]string)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to lock here, just before the code that changes info?

@bart0sh
Copy link
Contributor

bart0sh commented Mar 15, 2023

@moshe010 There seems to be a code that reads annotations and CDIDevices. It should be also locked, I believe.

@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Mar 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74123a7 into kubernetes:master Mar 15, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 15, 2023
@moshe010
Copy link
Contributor Author

@klueska @moshe010 any more context about this PR?

It just something that we missed when we merged #116513.

We spot it after merge.

@moshe010 moshe010 mentioned this pull request Mar 21, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@bart0sh bart0sh bart0sh left review comments

@dims dims Awaiting requested review from dims

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@klueska klueska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
[sig-release] Bug Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@moshe010 @k8s-ci-robot @ffromani @klueska @bart0sh @cici37