Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #116603: Aggregated discovery resilient to nil GVK #116666

Merged
merged 1 commit into from Mar 30, 2023
Merged

Automated cherry pick of #116603: Aggregated discovery resilient to nil GVK #116666

merged 1 commit into from Mar 30, 2023

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Mar 15, 2023 •
edited by liggitt

Cherry pick of #116603 on release-1.26.

#116603: Aggregated discovery resilient to nil GVK

This will fix problems caused by metrics aggregated api servers when the client is v1.26 and the api server is v1.27 (aggregated discovery turned on) or later.

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.26 regression in client-go discovery handling of aggregated responses containing nil entries

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2023
@seans3
Copy link
Contributor Author

seans3 commented Mar 15, 2023

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 15, 2023
@seans3
Copy link
Contributor Author

seans3 commented Mar 15, 2023

/cc @deads2k
/assign @Jefftree

@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 044574fc52230eb72ff9c8e18e44da19e2376ff5

@deads2k
Copy link
Contributor

deads2k commented Mar 15, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@seans3
Copy link
Contributor Author

seans3 commented Mar 15, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 15, 2023 19:10
@cici37
Copy link
Contributor

cici37 commented Mar 16, 2023

From release team: 1.26 patch release started yesterday and hasn't completed. Will merge after patch release is out. Thank you
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2023
@cici37 cici37 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9936142 into kubernetes:release-1.26 Mar 30, 2023
12 checks passed
@dims
Copy link
Member

dims commented Apr 19, 2023

possibly related to #117466 @seans3 ?

@dims dims mentioned this pull request Apr 19, 2023
Closed
@scrayos scrayos mentioned this pull request Apr 19, 2023
Closed
This was referenced May 5, 2023
Closed
Closed
@silenium-dev silenium-dev mentioned this pull request May 7, 2023
Closed
@dims dims mentioned this pull request May 31, 2023
Closed
@diskis diskis mentioned this pull request Jun 26, 2023
Closed
@tangledbytes tangledbytes mentioned this pull request Jul 10, 2023
Closed
2 tasks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 9, 2023
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@soltysh soltysh Awaiting requested review from soltysh

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@seans3 @Jefftree @k8s-ci-robot @deads2k @cici37 @dims @liggitt