Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear front proxy headers after authentication is complete #116785

Merged
merged 1 commit into from Mar 21, 2023
Merged

Clear front proxy headers after authentication is complete #116785

merged 1 commit into from Mar 21, 2023

Conversation

enj
Copy link
Member

@enj enj commented Mar 21, 2023

This matches the logic we have for the Authorization header as well as the impersonation headers.

/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2023
@enj
Clear front proxy headers after authentication is complete
e9866d2 
This matches the logic we have for the Authorization header as well
as the impersonation headers.

Signed-off-by: Monis Khan <mok@microsoft.com>
@enj enj force-pushed the enj/i/clean_front_proxy_headers branch from 0c7f08f to e9866d2 Compare March 21, 2023 14:51
@enj
Copy link
Member Author

enj commented Mar 21, 2023

/triage accepted
/milestone v1.27
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 21, 2023
@liggitt
Copy link
Member

liggitt commented Mar 21, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebd80ea1b25fb69ec20f46598b33fff05c6bd7fc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@enj
Copy link
Member Author

enj commented Mar 21, 2023

/retest

#107414 #116693

This was referenced Mar 21, 2023
Merged
Merged
Merged
@liggitt liggitt removed the area/test label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 956fa9b into kubernetes:master Mar 21, 2023
13 checks passed
k8s-ci-robot added a commit that referenced this pull request Mar 22, 2023
@k8s-ci-robot
Merge pull request #116817 from enj/automated-cherry-pick-of-#116785-…
754c1af 
…upstream-release-1.25

Automated cherry pick of #116785: Clear front proxy headers after authentication is complete
k8s-ci-robot added a commit that referenced this pull request Mar 22, 2023
@k8s-ci-robot
Merge pull request #116816 from enj/automated-cherry-pick-of-#116785-…
b85ffd2 
…upstream-release-1.26

Automated cherry pick of #116785: Clear front proxy headers after authentication is complete
k8s-ci-robot added a commit that referenced this pull request Mar 22, 2023
@k8s-ci-robot
Merge pull request #116818 from enj/automated-cherry-pick-of-#116785-…
93f0bdc 
…upstream-release-1.24

Automated cherry pick of #116785: Clear front proxy headers after authentication is complete
@liggitt liggitt mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@aojea aojea Awaiting requested review from aojea

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enj @liggitt @k8s-ci-robot