Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26] Cherry-pick of #116809: Fix CI regex for missing rc.0 tags #116808

Merged
merged 5 commits into from Mar 22, 2023
Merged

[1.26] Cherry-pick of #116809: Fix CI regex for missing rc.0 tags #116808

merged 5 commits into from Mar 22, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 21, 2023 •
edited

Cherry-pick of #116809

/kind bug
/kind failing-test
/priority critical-urgent

Makes the rc.0. portion of a CI build version optional.

Best reviewed commit by commit.

NONE

/sig release
xref kubernetes/release#2972

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2023
@liggitt liggitt changed the base branch from master to release-1.26 March 21, 2023 13:00
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 21, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@liggitt liggitt mentioned this pull request Mar 21, 2023
Closed
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2023
@liggitt liggitt closed this Mar 21, 2023
@liggitt liggitt reopened this Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2023
This was referenced Mar 21, 2023
Merged
Merged
Merged
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 21, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023

pushed debug commit
/hold for debug

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 21, 2023 •
edited

@liggitt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-conformance-kind-ipv6-parallel ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-capz-windows-containerd ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-capz-windows-containerd
pull-kubernetes-e2e-ubuntu-gce-network-policies ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-e2e-gci-gce-ingress ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-e2e-capz-azure-file ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-gci-gce-ipvs ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-gci-gce-ipvs
pull-kubernetes-e2e-kind-kms ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-kind-kms
pull-kubernetes-kind-dra ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-kind-dra
pull-kubernetes-e2e-capz-azure-disk-vmss ae9b5a251757c6b660cc80522cc041e8c23ca37e link false /test pull-kubernetes-e2e-capz-azure-disk-vmss

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023 •
edited

uh.... from https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/116808/pull-kubernetes-e2e-gce-ubuntu-containerd/1638187943069749248/ failure:

W0321 15:00:19.262] 2023/03/21 15:00:16 extract_k8s.go:304: U=file:///go/src/k8s.io/kubernetes/_output/gcs-stage R=v1.26.3-8+3f89980a10b33c get-kube.sh failed: error during /workspace/get-kube.sh: exit status 1
W0321 15:00:19.262] 2023/03/21 15:00:19 process.go:153: Running: /workspace/get-kube.sh
W0321 15:00:19.268] Version doesn't match regexp
W0321 15:00:19.268] 2023/03/21 15:00:19 process.go:155: Step '/workspace/get-kube.sh' finished in 5.870341ms

the debug bits I added around the Version doesn't match regexp message aren't even appearing, which means we're not running kube-up from this branch... I have no idea where CI is getting the kube-up content if not from the PR under test

@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023 •
edited

does kubekins scrape get-kube.sh from master, bake it into kubekins images, and then invoke it on release branches?

https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/Dockerfile#L115

that's... scary

@liggitt liggitt changed the title [1.26] Fix CI regex for missing rc.0 tags [1.26] Cherry-pick of #116809: Fix CI regex for missing rc.0 tags Mar 21, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023

/assign @cpanato @saschagrunert

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2023
cpanato
cpanato approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87ac17203ee113519425be0c3223eca8e76df9c0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2d51eba into kubernetes:release-1.26 Mar 22, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 22, 2023
@liggitt liggitt deleted the ci-regex-1.26 branch March 22, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @saschagrunert @cpanato