Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated pkg/scheduler/framework/preemption & defaultpreemption to use contextual logging #116835

Merged
merged 2 commits into from Apr 27, 2023
Merged

Migrated pkg/scheduler/framework/preemption & defaultpreemption to use contextual logging #116835

merged 2 commits into from Apr 27, 2023

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Mar 22, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Migrated the preemption scheduler plugin to use contextual logging

Which issue(s) this PR fixes:

Part of #91633 (comment)

Special notes for your reviewer:

the test file pkg/scheduler/framework/preemption/preemption_test.go is updated in PR #116842 https://github.com/kubernetes/kubernetes/pull/116842/files#diff-33df49b5fb3da50ca769dc3b9fc05cc3f55a0f7cd8877eba9047fa1a504f52de

Does this PR introduce a user-facing change?

Migrated `pkg/scheduler/framework/preemption` to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

/sig instrumentation
/wg structured-logging
/area logging
/sig scheduling

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2023
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu mentioned this pull request Mar 22, 2023
Open
@mengjiao-liu mengjiao-liu changed the title Migrated the preemption scheduler plugin to use contextual logging Migrated pkg/scheduler/framework/preemption to use contextual logging Mar 22, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-plugin-preemption branch from 12ce38d to dca53ba Compare March 22, 2023 06:36
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu mentioned this pull request Mar 23, 2023
Closed
@mengjiao-liu mengjiao-liu marked this pull request as ready for review March 23, 2023 09:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign @pohly

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-plugin-preemption branch from 0f95c63 to fcc9758 Compare April 4, 2023 11:09
@mengjiao-liu
Copy link
Member Author

mengjiao-liu commented Apr 4, 2023 •
edited

Moved PR #116633 to this PR based on this comment https://github.com/kubernetes/kubernetes/pull/116633/files#r1152703840.

@mengjiao-liu
Copy link
Member Author

/retest

@mengjiao-liu mengjiao-liu changed the title Migrated pkg/scheduler/framework/preemption to use contextual logging Migrated pkg/scheduler/framework/preemption & defaultpreemption to use contextual logging Apr 6, 2023
@knelasevero
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a892f2c85b5e2386e3abc9768776ca2d5d559d85

@knelasevero
Copy link
Contributor

/cc @alculquicondor
/cc @pohly

@kerthcet
Copy link
Member

Also /lgtm
/assign @alculquicondor

alculquicondor
alculquicondor reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some performance concern and general housekeeping based on https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md#message-style-guidelines

pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/preemption/preemption.go Outdated Show resolved Hide resolved
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-plugin-preemption branch from fcc9758 to 7d14345 Compare April 27, 2023 03:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-plugin-preemption branch from 7d14345 to 37a9260 Compare April 27, 2023 03:28
@mengjiao-liu
Copy link
Member Author

All comments addressed.

alculquicondor
alculquicondor reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06e91435954c3a1a0ced94134b19a87461ec711f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5170c25 into kubernetes:master Apr 27, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet kerthcet left review comments

@denkensk denkensk Awaiting requested review from denkensk

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@pohly pohly Awaiting requested review from pohly

@knelasevero knelasevero Awaiting requested review from knelasevero

Assignees

@pohly pohly

@alculquicondor alculquicondor

@knelasevero knelasevero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengjiao-liu @k8s-ci-robot @logicalhan @knelasevero @kerthcet @alculquicondor @pohly