Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e node: bump all nodes ready timeout #116947

Merged
merged 1 commit into from
May 2, 2023
Merged

e2e node: bump all nodes ready timeout #116947

merged 1 commit into from
May 2, 2023

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Mar 27, 2023 •
edited

What type of PR is this?

/kind flake

What this PR does / why we need it:

This PR bumps the node ready timeout from 3 minutes to 7 minutes.

Edit 4/26/2023 - In OpenShift we see various cloud providers have large variability when all nodes can become ready. We are carrying a patch for 7 minutes, which seems to catch all the providers we are testing.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Mar 27 10:25:06 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 27, 2023
@rphillips
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 27, 2023
@rphillips rphillips force-pushed the bump_all_nodes_ready_timeout branch from 9b7a366 to 86e1f4b Compare March 27, 2023 16:22
@bobbypage
Copy link
Member

Did something recently start flaking that makes us need this change?

@SergeyKanzhelev
Copy link
Member

@rphillips can you provide more explanation why it is needed?

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Mar 29, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Reviewer to PRs Waiting on Author in SIG Node CI/Test Board Mar 29, 2023
@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 30, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from PRs Waiting on Author to Triage in SIG Node CI/Test Board Apr 26, 2023
@rphillips
Copy link
Member Author

@bobbypage @SergeyKanzhelev I updated the description to why. OpenShift is seeing variability across various clouds and networking providers and is carrying a 7 minute patch like this one. Thoughts on including this upstream?

Note: we are not seeing issues in upstream k8s.

SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbypage @SergeyKanzhelev I updated the description to why. OpenShift is seeing variability across various clouds and networking providers and is carrying a 7 minute patch like this one. Thoughts on including this upstream?

Note: we are not seeing issues in upstream k8s.

I'm fine with this.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a89e65964c13cb18b5ae514d6f487d0c0f7234f9

@bart0sh
Copy link
Contributor

bart0sh commented Apr 27, 2023

/triage accepted
/priority important-soon
/assign @dims @mrunalp

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 27, 2023
@bart0sh bart0sh moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Apr 27, 2023
@dims
Copy link
Member

dims commented May 2, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrunalp, rphillips, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0a30e39 into kubernetes:master May 2, 2023
11 checks passed
SIG Node CI/Test Board automation moved this from Triage to Done May 2, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done May 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@dims dims

@mrunalp mrunalp

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rphillips @k8s-ci-robot @bobbypage @SergeyKanzhelev @bart0sh @dims @k8s-triage-robot @mrunalp