Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake TestGetListNonRecursive #116987

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Deflake TestGetListNonRecursive #116987

merged 1 commit into from
Apr 12, 2023

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Mar 29, 2023 •
edited

Fix: #116677

NONE

/sig api-machinery
/kind flake
/priority important-longterm

/assign @MadhavJivrajani

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 29, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Mar 29 10:30:37 UTC 2023.

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from enj March 29, 2023 11:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 29, 2023
@wojtek-t
Copy link
Member Author

/retest

MadhavJivrajani
MadhavJivrajani approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MadhavJivrajani, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b2d8448cdc8390f6830deaec81a3cca920d10ad

@liggitt
Copy link
Member

liggitt commented Mar 30, 2023

can you describe why the test is flaky? it's disconcerting to just expect a different result

@wojtek-t
Copy link
Member Author

can you describe why the test is flaky? it's disconcerting to just expect a different result

The semantic of "NotOlderThan" is basically that we any result from the point in time with RV >= the given one is ok.
So for those test cases with RV=0, pretty much any state returned is correct.
The other test cases cover situations that are more constained.

[FWIW - we consciously made all those tests parallel, so that we can actually uncover the races between testcases.]

@cici37
Copy link
Contributor

cici37 commented Mar 30, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2023
@liggitt
Copy link
Member

liggitt commented Mar 30, 2023

ok, thanks. you ran this with stress and the flake was gone?

@wojtek-t
Copy link
Member Author

ok, thanks. you ran this with stress and the flake was gone?

yup - seems to be gone now

@k8s-ci-robot k8s-ci-robot merged commit 01c0495 into kubernetes:master Apr 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

TestGetListNonRecursive is flaky
5 participants
@wojtek-t @k8s-ci-robot @liggitt @cici37 @MadhavJivrajani