-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create local copy to avoid potential race condition #116994
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Mar 29 16:30:31 UTC 2023. |
/assign UtopiaGithub @SergeyKanzhelev |
@mmiranda96: GitHub didn't allow me to assign the following users: UtopiaGithub. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
@UtopiaGitHub PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I vaguely remember there was linter added for this. But cannot find any references to this
LGTM label has been added. Git tree hash: 799cc385ffce54ec88f6d14ccd680fee27f30906
|
2023-03-29 12:56 GMT-07:00, Kubernetes Prow Robot ***@***.***>:
… Please note that we're already in [Test
Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze)
for the `release-1.27` branch. This means every merged PR will be
automatically fast-forwarded via the periodic
[ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward)
job to the release branch of the upcoming v1.27.0 release.
Fast forwards are scheduled to happen every 6 hours, whereas the most recent
run was: Wed Mar 29 16:30:31 UTC 2023.
--
Reply to this email directly or view it on GitHub:
#116994 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
/assign @yujuhong |
/area test |
/assign @mrunalp Can you pls approve? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmiranda96, mrunalp, pacoxu, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Create a local copy of testcase struct.
/sig node
/kind cleanup
/kind flake
What this PR does / why we need it:
When running parallel code inside a loop, it's important to avoid referencing the iterator in the loop condition directly, as it can change and we might end up accessing a different thing. To fix this, the best solution is to create a local copy of the struct.
Which issue(s) this PR fixes:
Fixes #116505
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None, this is a test-only change.