Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetLogs doesn't have support for Reactors in fake client #117144

Open
mjnovice opened this issue Apr 6, 2023 · 3 comments
Open

GetLogs doesn't have support for Reactors in fake client #117144

mjnovice opened this issue Apr 6, 2023 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mjnovice
Copy link

mjnovice commented Apr 6, 2023 •
edited

What would you like to be added?

GetLogs should be supported just like any other entity and verb in fakeClient, so that we can mock the GetLogs for unit test.
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/kubernetes/typed/core/v1/fake/fake_pod_expansion.go#L66

Why is this needed?

Allows for unit testing of GetLogs function
@mjnovice mjnovice added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Apr 25, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2023
@cici37
Copy link
Contributor

cici37 commented Apr 25, 2023

/help wanted
If there is a PR raised, we would be happy to review. However, we currently don't have resource for this. :)
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 25, 2023
@gdhuper
Copy link

gdhuper commented Jun 23, 2023

@mjnovice I am interested in working on this. Can you provide a little more context on this? Specifically what do you mean by Reactors? (still very new to this codebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pacoxu @mjnovice @cici37 @gdhuper @k8s-ci-robot