Add warning log callback in client-go loading rules #117233
Merged
+89
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a way to consumers use their own custom warning mechanisms instead default klog warning.
k8s-ci-robot
added
release-note-none
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/cc @yliaog |
|
Since the previous attempt was reviewed by @yliaog, could you please take a look at this one?. Thanks. |
|
/assign @liggitt |
liggitt
reviewed
May 23, 2023
|
|
||
| func (handler WarningHandler) Warn(message string) { | ||
| if handler == nil { | ||
| klog.V(1).Info(message) |
There was a problem hiding this comment.
what is the difference in output between klog.Warningf and klog.V(1).Info?
There was a problem hiding this comment.
klog.Warning prints;
W0524 09:11:16.915498 42167 loader.go:142] Config not found:
klog.V(1).Info prints(only after --verbosity >= 1);
I0524 08:48:15.896816 40664 loader.go:142] Config not found:
liggitt
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b16e911e95d0a542efea7ab8ce900681289aff65
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @liggitt. We are lucky that we have you for these portions of the code base. |
rayowang
pushed a commit
to rayowang/kubernetes
that referenced
this pull request
Feb 9, 2024
* Add warning log callback in client-go loading rules This provides a way to consumers use their own custom warning mechanisms instead default klog warning. * Use typed error instead plain string * Fix interface change in unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This provides a way to consumers use their own custom warning mechanisms instead default klog warning.
This PR takes over the previous good attempt #114793 to fix that issue.
Which issue(s) this PR fixes:
Fixes #94428
Special notes for your reviewer:
Does this PR introduce a user-facing change?