-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change pv recycler scrub cmd to find -delete #117283
Conversation
PVs with large amount of files cannot be recycted with "rm" command and are left in "Failed" state. Hence we are switching to "find -delete" command.
Welcome @defo89! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @defo89. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kindly ping @mauriciopoppe @SergeyKanzhelev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/assign @msau42
LGTM label has been added. Git tree hash: 142231bad07a436f29485b19d990e6ac33a5c246
|
Can you add a release note describing the bug this is fixing? |
@msau42 release note added |
/approve Thanks! |
/assign @cheftako |
kindly pinging @cheftako @dchen1107 as approvers |
@@ -3115,7 +3115,7 @@ spec: | |||
- /bin/sh | |||
args: | |||
- -c | |||
- test -e /scrub && rm -rf /scrub/..?* /scrub/.[!.]* /scrub/* && test -z $(ls -A /scrub) || exit 1 | |||
- test -e /scrub && find /scrub -mindepth 1 -delete && test -z $(ls -A /scrub) || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to use the -ignore_readdir_race option with the 'find -delete' ?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, defo89, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
PVs with large amount of files cannot be recycted with "rm" command and are left in "Failed" state.
Hence we are switching to "find -delete" command.
Which issue(s) this PR fixes:
Fixes #117189
Does this PR introduce a user-facing change?