Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117258: kube-aggregator: correctly use client-go TLS cache with #117311

Merged
merged 1 commit into from Apr 28, 2023
Merged

Automated cherry pick of #117258: kube-aggregator: correctly use client-go TLS cache with #117311

merged 1 commit into from Apr 28, 2023

Conversation

enj
Copy link
Member

@enj enj commented Apr 13, 2023 •
edited by liggitt

Cherry pick of #117258 on release-1.26.

#117258: kube-aggregator: correctly use client-go TLS cache with

For details on the cherry pick process, see the cherry pick requests page.

Fixed a 1.26 regression causing a memory leak in the Kubernetes API server that occurs during APIService processing.

@enj
kube-aggregator: correctly use client-go TLS cache with custom dialer
83f6cb6 
Signed-off-by: Monis Khan <mok@microsoft.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 13, 2023
@enj
Copy link
Member Author

enj commented Apr 13, 2023

/kind bug
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 13, 2023
@liggitt
Copy link
Member

liggitt commented Apr 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43c8b323658ba0c3bc188532d83181c0327f52a4

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@liggitt
Copy link
Member

liggitt commented Apr 13, 2023

This is intentionally only picked back to 1.26 (and not 1.25 or 1.24) since it is resolving an issue introduced in 1.26 (in #112450)

@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 13, 2023
@enj
Copy link
Member Author

enj commented Apr 13, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team April 13, 2023 20:54
@enj enj mentioned this pull request Apr 13, 2023
Merged
@jimangel
Copy link
Member

/lgtm

deferring cherry-pick to @kubernetes/release-managers

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 14, 2023
Merged
xmudrii
xmudrii approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4e453e0 into kubernetes:release-1.26 Apr 28, 2023
15 checks passed
@dmitry-irtegov dmitry-irtegov mentioned this pull request Jun 16, 2023
Open
@enj enj deleted the automated-cherry-pick-of-#117258-upstream-release-1.26 branch June 23, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@liggitt liggitt

@jimangel jimangel

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enj @liggitt @k8s-ci-robot @jimangel @xmudrii