Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117073: Fix: Recreate DaemonSet pods completed with Succeeded phase #117496

Merged
merged 1 commit into from Apr 27, 2023
Merged

Automated cherry pick of #117073: Fix: Recreate DaemonSet pods completed with Succeeded phase #117496

merged 1 commit into from Apr 27, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Apr 20, 2023 •
edited by liggitt

Cherry pick of #117073 on release-1.26.

#117073: Recreate DaemonSet pods completed with Succeeded phase

For details on the cherry pick process, see the cherry pick requests page.

Fix recreating DaemonSet pods completed with Succeeded phase

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 20, 2023
@mimowo mimowo changed the title Automated cherry pick of #117073: Investigate and fix the handling of Succeeded pods in Automated cherry pick of #117073: Fix: Recreate DaemonSet pods completed with Succeeded phase Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 20, 2023
@mimowo mimowo mentioned this pull request Apr 20, 2023
Merged
@mimowo
Copy link
Contributor Author

mimowo commented Apr 20, 2023

/sig apps
cc @alculquicondor @liggitt @bobbypage

@liggitt
Copy link
Member

liggitt commented Apr 20, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e46404a48e0d0c37c2e622e2dc23222507171fe

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@bobbypage
Copy link
Member

/lgtm

@mimowo
Investigate and fix the handling of Succeeded pods in DaemonSet
2e10078 
Resolved conflict by using klog instead of logger
@mimowo mimowo force-pushed the automated-cherry-pick-of-#117073-upstream-release-1.26 branch from 19093a7 to 2e10078 Compare April 20, 2023 08:44
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Apr 20, 2023

Adapted the logger use to 1.26: https://github.com/kubernetes/kubernetes/compare/19093a7b1567d95cba36e89652215dabcf948e68..2e100780a72b0e3ac3b5698d53dacafa4bb9871e

@mimowo
Copy link
Contributor Author

mimowo commented Apr 20, 2023

@bobbypage please renew the lgtm after the conflict resolution. The tests pass.
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team April 20, 2023 10:04
@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a851e73e72de6649600ac8e6eaebdfb65bfc099

@mimowo
Copy link
Contributor Author

mimowo commented Apr 20, 2023

@kubernetes/release-managers PTAL

xmudrii
xmudrii approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mimowo, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Apr 27, 2023

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 27, 2023
@liggitt
Copy link
Member

liggitt commented Apr 27, 2023

/remove-kind regression

actually, I don't think this was a regression in 1.26... this is a fix of an existing bug that got exposed in 1.27 by kubelet changes

@k8s-ci-robot k8s-ci-robot removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 208b633 into kubernetes:release-1.26 Apr 27, 2023
16 checks passed
@mimowo mimowo deleted the automated-cherry-pick-of-#117073-upstream-release-1.26 branch November 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@soltysh soltysh Awaiting requested review from soltysh

@bobbypage bobbypage Awaiting requested review from bobbypage

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@bobbypage bobbypage

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mimowo @k8s-ci-robot @liggitt @bobbypage @xmudrii