New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nodes resource from CoreDNS RBAC manifest #117521
Conversation
This commit syncs RBAC from coredns/deployment and removes a get nodes RBAC. Historically the federation CoreDNS plugin needed the nodes resource to fetch zone and region labels. However, the CoreDNS federation plugin was deprecated and cleaned up a long time ago and removed the Nodes RBAC requirement here in `coredns/deployment` coredns.yaml.sed: coredns/deployment#229 This change however, never made it to `kubernetes/kubernetes`. Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @nberlee. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test |
/test pull-kubernetes-unit |
/assign dpasiukevich @MrHohn |
/approve |
/assign @johnbelamaric |
/approve |
LGTM label has been added. Git tree hash: c4cfe6d861c53f74cceacea74078a346ab6cffd7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, MrHohn, nberlee, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
follows kubernetes/kubernetes#117521 Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This commit syncs RBAC from coredns/deployment and removes a get nodes RBAC.
Historically the federation CoreDNS plugin needed the nodes resource to fetch zone and region labels.
However, the CoreDNS federation plugin was deprecated and cleaned up a long time ago and removed the Nodes RBAC requirement here in
coredns/deployment
coredns.yaml.sed: coredns/deployment#229This change however, never made it to
kubernetes/kubernetes
.Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: