user --prune-allowlist in kube-addons.sh

[pacoxu]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #113116

Special notes for your reviewer:

• follow up: we should remove --prune-whitelist in v1.28 or later. remove PruneWhitelist, use prune-allowlist instead #120246

Does this PR introduce a user-facing change?

None

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacoxu]

/cc @brianpursley @KnVerey

[brianpursley]

I'm not familiar with addon-manager, but the --prune-whitelist is deprecated and replaced by --prune-allowlist in kubectl. It still exists for now in a deprecated state, but will be removed at some point in the future (version 1.28 or later)

So it could make sense to update the kubectl command here in anticipation of that, depending on how far back you need to support kubectl versions since the --prune-allowlist didn't exist until recently.

[pacoxu]

@MrHohn do you have time to take a look?

[MrHohn]

Sorry this falls off my radar. This LGTM.

Would you need a new kube-addon-manager released for this? If so, let's also bump the version in Makefile and add CHANGELOG entry for this.

cc @spencer-p

/approve

[spencer-p]

It looks like the cluster/addons/addon-manager/Makefile is still installing kubectl 1.20.2, which I assume needs to be bumped to use the new flag as well.

…

Message ID: ***@***.***>

[MrHohn]

Thanks, this looks good. Could you update https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/CHANGELOG.md as well with this new version?

[pacoxu]

Thanks, this looks good. Could you update https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/CHANGELOG.md as well with this new version?

I updated it to v9.1.7.

[pacoxu]

Later, I will update registry.k8s.io/addon-manager/kube-addon-manager image version after the new version image is ready.

kubernetes/cluster/gce/manifests/kube-addon-manager.yaml

Lines 26 to 27 in f562375

	image: registry.k8s.io/addon-manager/kube-addon-manager:v9.1.6
	command:

[MrHohn]

Thanks!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 68e15dc3337d80966a8174214b7c50aabc224f89

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster/addons/addon-manager/OWNERS [MrHohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment