New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add ipfamilies tweak functions #117595
Chore: add ipfamilies tweak functions #117595
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mowangdk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@thockin ptal, new added test cases cleanup |
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
41eea84
to
1c4d3ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: 78fd66a7b470fd314ddb430319f76aafc55cfce5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mowangdk, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You're going to make this into the nicest test file in the codebase :) |
1c4d3ae
to
152c1a0
Compare
/ok-to-test |
LGTM label has been added. Git tree hash: f4d518c003c6bf851db1ab6e8c64ffb7257b4b3d
|
/release-note none |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cleanup unit test. some finishing work about #116277
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?