Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the etcd base image to v1.4.2 #117643

Merged
merged 2 commits into from Apr 27, 2023
Merged

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 27, 2023

The current base v1.3.0 has CVEs[1] which are addressed in latest versions of the bullseye image

[1] ex:
CVE-2022-2509
CVE-2021-46828

/kind cleanup

NONE

Additional note for reviewer:

The plan was to update the etcd docker file base image to v1.4.2, however the external dependencies check fails while we update only this part, so the base image version has been bumped to v1.4.2 in general. I am not sure, were there any specific reason to stick to v1.3.0 of bullseye in the dependencies.yaml and conformance test image.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2023

/cc @ahrtr

@k8s-ci-robot
Copy link
Contributor

@humblec: GitHub didn't allow me to request PR reviews from the following users: ahrtr.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ahrtr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2023

cc @jpbetz @serathius

The current base v1.3.0 has many CVEs[1] which are addressed in latest
versions of the bullseye

[1] ex:
CVE-2022-2509
CVE-2021-46828

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 27, 2023
@ahrtr
Copy link
Member

ahrtr commented Apr 27, 2023

Does it mean that K8s build etcd image itself instead of using etcd officially released image (e.g. gcr.io/etcd-development/etcd:v3.5.8)?

Currently etcd's base image is gcr.io/distroless/static-debian11, which should be much safer than bullseye. FYI. etcd-io/etcd#15016

@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2023

cc @saschagrunert

@serathius
Copy link
Contributor

Does it mean that K8s build etcd image itself instead of using etcd officially released image (e.g. gcr.io/etcd-development/etcd:v3.5.8)?

Yes, k8s uses etcd binaries, but rolls out it's own image with own scripting. For example they implement multi minor version upgrades. My work on etcdutl migrate was to replace tooling here https://github.com/kubernetes/kubernetes/tree/master/cluster/images/etcd.

Currently etcd's base image is gcr.io/distroless/static-debian11, which should be much safer than bullseye. FYI. etcd-io/etcd#15016

Yes, but k8s has its own backward incompatibility policies that are stricter than etcd. etcd just switched base image and even backport it (I was not a fan of that). Kubernetes community just cannot do this to it's user. That's maybe a reason why people prefer this image.

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 210f0e3c003881abb0f6e7d0620907ac2cd0c69a

@ahrtr
Copy link
Member

ahrtr commented Apr 27, 2023

Yes, k8s uses etcd binaries, but rolls out it's own image with own scripting.

thx for the clarification. Is the image only used for K8s's pipeline testing? Each cloud provider can choose etcd image or binary (e.g. use the etcd officially released binaries or images) themselves.

@serathius
Copy link
Contributor

serathius commented Apr 27, 2023

Yes, k8s uses etcd binaries, but rolls out it's own image with own scripting.

thx for the clarification. Is the image only used for K8s's pipeline testing? Each cloud provider can choose etcd image or binary (e.g. use the etcd officially released binaries or images) themselves.

It's treated more as an official K8s etcd image. As you said, each K8s distribution may pick etcd image as they want, however i think most of them pick this one. I think this is driven by misunderstanding of kubernetes-etcd compatibility. I have seen announcements "K8s now supports etcd v3.5" written based on fact that we bumped this image. You are right about the real purpose, this image is to test K8s code in CI and during releases.

@dims
Copy link
Member

dims commented Apr 27, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2023

/test pull-kubernetes-unit

@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2023

/test pull-kubernetes-e2e-gce

@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a15029 into kubernetes:master Apr 27, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants