Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ENABLE_AUTH_PROVIDER_GCP to true in gce tests #117671

Merged
merged 1 commit into from Apr 28, 2023
Merged

Set ENABLE_AUTH_PROVIDER_GCP to true in gce tests #117671

merged 1 commit into from Apr 28, 2023

Conversation

pawbana
Copy link
Contributor

@pawbana pawbana commented Apr 28, 2023 •
edited

/kind feature

What this PR does / why we need it:

This PR enables external credential provider in kubelet in tests on gce.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2023
@pawbana
Copy link
Contributor Author

pawbana commented Apr 28, 2023

/cc @ndixita
/cc @ruiwen-zhao
/cc @ibabou

@pawbana pawbana mentioned this pull request Apr 28, 2023
Merged
ibabou
ibabou approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@ibabou ibabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawel!

@ibabou
Copy link
Contributor

ibabou commented Apr 28, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 119b6e41067132b070400f14ba6eaa934692e6b2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@ibabou
Copy link
Contributor

ibabou commented Apr 28, 2023

/triage accepted
/approve
/sig windows

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibabou, pawbana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibabou
Copy link
Contributor

ibabou commented Apr 28, 2023 •
edited

@pawbana It still have "do-not-merge/release-note-label-needed", so you'll need to update the that.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 28, 2023
@pawbana
Copy link
Contributor Author

pawbana commented Apr 28, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit be7b2ee into kubernetes:master Apr 28, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 28, 2023
@aojea
Copy link
Member

aojea commented Apr 29, 2023

folks we need to coordinate, there is a whole effort to remove the intree cloud-providers and the matrix of testing is complex
If you enable this here this will affect all the tests, but the combination of flags is convoluted
#114557 and we don't even know what things are being tested

/cc @liggitt @andrewsykim @cheftako

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibabou ibabou ibabou approved these changes

@ndixita ndixita Awaiting requested review from ndixita

@ruiwen-zhao ruiwen-zhao Awaiting requested review from ruiwen-zhao

@bowei bowei Awaiting requested review from bowei

@mwielgus mwielgus Awaiting requested review from mwielgus

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@ibabou ibabou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pawbana @ibabou @k8s-ci-robot @aojea