Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the changelog for GlusterFS removal in 1.26. #117678

Merged
merged 1 commit into from Apr 29, 2023
Merged

Correct the changelog for GlusterFS removal in 1.26. #117678

merged 1 commit into from Apr 29, 2023

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Apr 28, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

#112015 should have had an ACTION_REQUIRED in the release notes as it is definitely impactful to users.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2023
@msau42
Copy link
Member Author

msau42 commented Apr 28, 2023

/assign @leonardpahlke @jeremyrickard
@kubernetes/release-managers

@leonardpahlke
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 614f1535edc8cfc09b0f62c55ee0f2299af64e53

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@msau42 msau42 mentioned this pull request Apr 28, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit c5aead3 into kubernetes:master Apr 29, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 29, 2023
@humblec
Copy link
Contributor

humblec commented Apr 29, 2023

Thanks @msau42 👍

k8s-ci-robot added a commit that referenced this pull request Apr 29, 2023
@k8s-ci-robot
Merge pull request #117680 from msau42/automated-cherry-pick-of-#1176…
1f16a36 
…78-upstream-release-1.26

Automated cherry pick of #117678: Correct the changelog for GlusterFS removal in 1.26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

@puerco puerco Awaiting requested review from puerco

Assignees

@jeremyrickard jeremyrickard

@leonardpahlke leonardpahlke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@msau42 @k8s-ci-robot @leonardpahlke @humblec @xmudrii @jeremyrickard