test/e2e_node: move getSampleDevicePluginPod to a test-only source file

[hyangah]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

image_list.go is one of the files included in the non-test variant Go build list, but its getSampleDevicePluginPod function references readDaemonSetV1OrDie function defined in device_plugin_test.go which is included in the test variant Go build list only. (The file name is *_test.go).

As a result, "go build" fails with the undefined reference error.

In practice, that may not be an issue since k8s project contributors aren't meant to run go build on this package. However, tools that depend on go build to operate - e.g., gopls or govulncheck ./... - will report this as an error.

Fix this error and make test/e2e package pass go build by moving this file to also test-only source code (device_plugin_test.go)

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hyangah / name: Hyang-Ah Hana Kim (9aca0f4e49eb633487e32ffba316231896b9fee1)

[k8s-ci-robot]

Hi @hyangah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @hyangah!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ffromani]

/release-note none
/ok-to-test

[ffromani]

/triage accepted
/priority backlog

[hyangah]

/easycla

[hyangah]

Thanks. Moved getSampleDevicePluginPod to device_plugin_test.go, and squashed the commits.

[ffromani]

/lgtm

thanks @hyangah for addressing the feedback so quickly!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1a5dfebba1f10d620df37e54acb4431cbfbcbd75

[bart0sh]

/retest

[bart0sh]

/unhold

[bart0sh]

/assign @klueska @mrunalp

[ffromani]

Being this a e2e_node only change, perhaps @SergeyKanzhelev or @endocrimes could also help here?

[SergeyKanzhelev]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hyangah, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e_node/OWNERS [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

Thanks for this, I just fixed something similar introduced during 1.28 dev in #119542

It looks like your PR fixes the only errors using govulncheck against release-1.27, release-1.26, and release-1.25. Would you mind opening cherry-picks of this PR to those branches?