Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move glusterfs 1.25 deprecation notice to the deprecation section. #117711

Merged
merged 1 commit into from May 2, 2023
Merged

Move glusterfs 1.25 deprecation notice to the deprecation section. #117711

merged 1 commit into from May 2, 2023

Conversation

msau42
Copy link
Member

@msau42 msau42 commented May 1, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The release note was incorrectly categorized as "other"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2023
@msau42
Copy link
Member Author

msau42 commented May 2, 2023

/retest

1 similar comment
@msau42
Copy link
Member Author

msau42 commented May 2, 2023

/retest

@msau42
Copy link
Member Author

msau42 commented May 2, 2023

/assign @xmudrii

cc @kubernetes/release-managers

@msau42
Copy link
Member Author

msau42 commented May 2, 2023

/assign @cici37
as 1.25 release manager

@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/lgtm
/approve
Thanks for raising it!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ccf1776695b4c081e864b26cacbd0af513dd6e51

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@cici37
Copy link
Contributor

cici37 commented May 2, 2023

Extra notes: it was added as "Other (cleanup/flake)" instead of "deprecations" because of the label in originally PR suggested so: #111485. Thanks for fixing it!

@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@cici37
Copy link
Contributor

cici37 commented May 2, 2023

There are other places in the 1.25 CHANGLOG also include this deprecation in the wrong session. Would you mind fixing it together?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@msau42
Copy link
Member Author

msau42 commented May 2, 2023

Thanks for the catch, I added it to the "1.25.0" section. Do you think the ".beta, .alpha" sections are necessary?

cici37
cici37 reviewed May 2, 2023
View reviewed changes
CHANGELOG/CHANGELOG-1.25.md
@@ -1425,6 +1425,7 @@ ConfigMap rendering [issue](https://github.com/kubernetes/kubernetes/issues/1120
- The beta `PodSecurityPolicy` admission plugin, deprecated since 1.21, is removed. Follow the instructions at https://kubernetes.io/docs/tasks/configure-pod-container/migrate-from-psp/ to migrate to the built-in PodSecurity admission plugin (or to another third-party policy webhook) prior to upgrading to v1.25. ([#109798](https://github.com/kubernetes/kubernetes/pull/109798), [@liggitt](https://github.com/liggitt))
- VSphere releases less than 7.0u2 are not supported for in-tree vSphere volume as of Kubernetes v1.25. Please consider upgrading vSphere (both ESXi and vCenter) to 7.0u2 or above. ([#111255](https://github.com/kubernetes/kubernetes/pull/111255), [@divyenpatel](https://github.com/divyenpatel))
- Windows winkernel kube-proxy no longer supports Windows HNS v1 APIs. ([#110957](https://github.com/kubernetes/kubernetes/pull/110957), [@papagalu](https://github.com/papagalu))
- GlusterFS provisioner (`kubernetes.io/glusterfs`) has been deprecated in this release. ([#111485](https://github.com/kubernetes/kubernetes/pull/111485), [@humblec](https://github.com/humblec))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna remove this one since it has been moved to ### Deprecation session: https://github.com/kubernetes/kubernetes/blob/7534d18847af7349dca0b98bb404645e282a0586/CHANGELOG/CHANGELOG-1.25.md?plain=1#L1671

And also this line: https://github.com/kubernetes/kubernetes/blob/7534d18847af7349dca0b98bb404645e282a0586/CHANGELOG/CHANGELOG-1.25.md?plain=1#L2150
may worth to move up in ### Deprecation as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks done

@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/unhold
/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e286e378a3bead0d41157035994bccc6937a051a

@msau42 msau42 mentioned this pull request May 2, 2023
Merged
@msau42
Copy link
Member Author

msau42 commented May 2, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit f3cf92b into kubernetes:master May 2, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 2, 2023
k8s-ci-robot added a commit that referenced this pull request May 3, 2023
@k8s-ci-robot
Merge pull request #117736 from msau42/automated-cherry-pick-of-#1177…
1309167 
…11-upstream-release-1.25

Automated cherry pick of #117711: Move glusterfs 1.25 deprecation notice to the deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 cici37 left review comments

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@cici37 cici37

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msau42 @k8s-ci-robot @cici37 @xmudrii