Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow runtimes to provide additional context on CRI pull errors #117935

Merged
merged 1 commit into from May 23, 2023
Merged

Allow runtimes to provide additional context on CRI pull errors #117935

merged 1 commit into from May 23, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Right now container runtimes have no way to provide additional context to the pull errors. We now loosen the constraints and check for additional messages after the actual CRI errors, which allows to enrich the verbosity of the warning events, for example:

Warning  Failed     2s (x3 over 43s)   kubelet            Failed to pull image "localhost:5000/foo": RegistryUnavailable: pinging container registry localhost:5000: Get "http://localhost:5000/v2/": dial tcp [::1]:5000: connect: connection refused

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Follow-up on: #117717

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2023
@saschagrunert
Copy link
Member Author

PTAL @kubernetes/sig-node-pr-reviews @haircommander @mrunalp

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@haircommander
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 12, 2023
@saschagrunert
Allow runtimes to provide additional context on CRI pull errors
aa405c8 
Right now container runtimes have no way to provide additional context
to the pull errors. We now loosen the constraints and check for
additional messages after the actual CRI errors, which allows to enrich
the verbosity of the warning events, for example:

```
Warning  Failed     2s (x3 over 43s)   kubelet            Failed to pull image "localhost:5000/foo": RegistryUnavailable: pinging container registry localhost:5000: Get "http://localhost:5000/v2/": dial tcp [::1]:5000: connect: connection refused
```

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/retest

@bart0sh
Copy link
Contributor

bart0sh commented May 15, 2023

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage May 15, 2023
@bart0sh
Copy link
Contributor

bart0sh commented May 15, 2023

/cc

@k8s-ci-robot k8s-ci-robot requested a review from bart0sh May 15, 2023 11:21
@haircommander
Copy link
Contributor

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e41100c99d4182c595fae28e445377840ca61ebe

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage May 16, 2023
@saschagrunert saschagrunert mentioned this pull request May 22, 2023
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@pacoxu pacoxu mentioned this pull request May 23, 2023
Open
7 tasks
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce aa405c8 link unknown /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented May 23, 2023

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 1cad20d into kubernetes:master May 23, 2023
10 of 12 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done May 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 23, 2023
@saschagrunert saschagrunert deleted the cri-errors-additional branch May 23, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp mrunalp approved these changes

@endocrimes endocrimes Awaiting requested review from endocrimes

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @haircommander @bart0sh @k8s-ci-robot @pacoxu @mrunalp