Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix a bug where the static pod changes detection logic is inconsistent with kubelet #118069

Merged
merged 1 commit into from May 18, 2023
Merged

kubeadm: fix a bug where the static pod changes detection logic is inconsistent with kubelet #118069

merged 1 commit into from May 18, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented May 17, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubeadm: fix a bug where the static pod changes detection logic is inconsistent with kubelet

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#2877

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: fix a bug where the static pod changes detection logic is inconsistent with kubelet

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 17, 2023
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
carlory
carlory reviewed May 17, 2023
View reviewed changes
cmd/kubeadm/app/util/staticpod/utils_test.go
namespace: kube-system
spec:
containers:
- image: gcr.io/google_containers/etcd-amd64:3.1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value of the image is not equal to other

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the manifest is just for test purpose, so the value is irrelevant.

neolit123
neolit123 reviewed May 18, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3409a75f91411e6465ae30b623f493e7bf2ee7d8

@k8s-ci-robot k8s-ci-robot merged commit f9d97e0 into kubernetes:master May 18, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 18, 2023
This was referenced May 18, 2023
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 19, 2023
@k8s-ci-robot
Merge pull request #118109 from SataQiu/automated-cherry-pick-of-#118…
4b47404 
…069-upstream-release-1.24

Automated cherry pick of #118069: kubeadm: fix a bug where the static pod changes detection
k8s-ci-robot added a commit that referenced this pull request May 19, 2023
@k8s-ci-robot
Merge pull request #118108 from SataQiu/automated-cherry-pick-of-#118…
7b5f620 
…069-upstream-release-1.25

Automated cherry pick of #118069: kubeadm: fix a bug where the static pod changes detection
k8s-ci-robot added a commit that referenced this pull request May 19, 2023
@k8s-ci-robot
Merge pull request #118106 from SataQiu/automated-cherry-pick-of-#118…
f3b2857 
…069-upstream-release-1.26

Automated cherry pick of #118069: kubeadm: fix a bug where the static pod changes detection
k8s-ci-robot added a commit that referenced this pull request May 19, 2023
@k8s-ci-robot
Merge pull request #118105 from SataQiu/automated-cherry-pick-of-#118…
4025005 
…069-upstream-release-1.27

Automated cherry pick of #118069: kubeadm: fix a bug where the static pod changes detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@carlory carlory carlory left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Kubeadm upgrade stuck in "Static pod: etcd-xxxx hash: xxxx" occasionally
4 participants
@SataQiu @k8s-ci-robot @neolit123 @carlory