Support podman for building release images #118073
Conversation
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
hack/lib/util.sh
Outdated
| @@ -729,7 +729,7 @@ function kube::util::ensure-cfssl { | |||
| # Check if we have "docker buildx" commands available | |||
| # | |||
| function kube::util::ensure-docker-buildx { | |||
| if docker buildx >/dev/null 2>&1; then | |||
| if docker buildx version >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Is anything else incompatible?
There was a problem hiding this comment.
Reworked to if docker buildx version || docker buildx; then .... One of them must succeed to declare buildx as supported.
There was a problem hiding this comment.
checking with version is fine, I mean that we've had explicit checks in other places at times that we're actually using docker because podman has a tendency to not actually be drop-in compatible with any of the commands, and we don't really have the bandwidth for that in the k8s builds
whereas this patch on it's own was fine.
There was a problem hiding this comment.
whereas this patch on it's own was fine.
+10000
podman returns nozero exit code for `docker buildx`, because it misses a subcommand. `docker buildx version` should work both in podman and docker. Tested both with docker-ce-20.10.18 + docker-buildx-plugin-0.10.2 and podman-4.5.0 + podman-docker.
|
/sig architecture |
k8s-ci-robot
added
sig/architecture
|
/remove-sig architecture |
k8s-ci-robot
added
sig/release
|
/approve |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 54a0f4e1b029ec6623f7dfd1ac891455a5c20036
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
podman returns nozero exit code for
docker buildx, because it misses a subcommand.Use
docker buildx versionthat works both in podman and docker. Tested both with docker-ce-20.10.18 + docker-buildx-plugin-0.10.2 and podman-4.5.0 + podman-docker.make quick-release-images(needed bykind build node-image) now succeeds.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: