Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26] Automated cherry pick of #118027: etcd: Update version to 3.5.9 #118078

Merged
merged 3 commits into from Sep 14, 2023
Merged

[1.26] Automated cherry pick of #118027: etcd: Update version to 3.5.9 #118078

merged 3 commits into from Sep 14, 2023

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented May 17, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cherry-picks #118027 to release-1.26.

For why we need to cherry-pick, see #117648. 3.5.8 fixed critical security vulnerabilities.

Which issue(s) this PR fixes:

For #117648

Does this PR introduce a user-facing change?

etcd: update to v3.5.9

@humblec @nikhita
update etcd version in install.sh to 3.5.9
f3f5b73 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec @nikhita
use upstream etcd github path instead of redirecting one
12669bd 
In the installation script we use coreos/etcd path which redirect
to etcd-io/etcd. This commit replace the same.

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec @nikhita
updating dependencies.yaml for etcd v3.5.9 version
dd8c1b9 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone May 17, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework labels May 17, 2023
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2023
@neolit123
Copy link
Member

/approve

@cici37
Copy link
Contributor

cici37 commented May 18, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 18, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

/lgtm
/assign @serathius @dims
/retest
This is still valid.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bd87c49e5542d9cd2614bcf36fcb3338187aeccd

@pacoxu
Copy link
Member

pacoxu commented Sep 12, 2023

/assign @liggitt
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 12, 2023 05:11
@serathius
Copy link
Contributor

/lgtm
/approve

@dims
Copy link
Member

dims commented Sep 12, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@neolit123
Copy link
Member

there is no cherry pick for 1.28. please see at the bottom here:
#118027

@saschagrunert
Copy link
Member

Not merging before #118079 lifts the hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, neolit123, nikhita, saschagrunert, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 14, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2023

/skip
/retest

@k8s-ci-robot k8s-ci-robot merged commit 6624292 into kubernetes:release-1.26 Sep 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@dims dims

@liggitt liggitt

@pacoxu pacoxu

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@nikhita @k8s-ci-robot @neolit123 @cici37 @pacoxu @serathius @dims @saschagrunert @liggitt @humblec