-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing windows memory allocation e2e tests after a refactor #118185
Fixing windows memory allocation e2e tests after a refactor #118185
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig windows |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
6147594
to
cba8c1f
Compare
/hold cancel |
/test ls |
@marosset: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm The PR message is correct, and is backed by the comment above the change. |
LGTM label has been added. Git tree hash: 00451f9a5df91f6fdfd522f74b0d7ec52e013c5c
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
#117962 accidently reversed a check in a Windows e2e test to ensure we have Windows nodes in the cluster.
This PR fixes that issue
https://testgrid.k8s.io/sig-windows-master-release#capz-windows-2022-master-serial-slow
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: