Automated cherry pick of #117586: Add DisruptionTarget condition when preempting for critical

[mimowo]

Cherry pick of #117586 on release-1.26.

#117586: Add DisruptionTarget condition when preempting for critical

For details on the cherry pick process, see the cherry pick requests page.

Add DisruptionTarget condition to the pod preempted by Kubelet to make room for a critical pod

[mimowo]

/assign @dchen1107

[mimowo]

Note: here I had to resolve conflicts as Context wasn't passed to ginkgo test functions in 1.26. Thus, I pass the TODO context here: https://github.com/kubernetes/kubernetes/pull/118221/files#diff-94cfb00d75a10103bd0a3476b3db35446dbde4c4050913210445023abad3ae38R124. This is an analogous to the other pre-existing test in the file.

[mimowo]

/test pull-kubernetes-e2e-kind-ipv6

[mimowo]

/assign @bobbypage

[bart0sh]

/kind bug
/triage accepted
/priority important-soon

[SergeyKanzhelev]

/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions

[SergeyKanzhelev]

/lgtm cancel

new tests are failing. Trying the test again, but it passed on 1.27 meaning that it may be a real issue

/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions

[SergeyKanzhelev]

re-run also failed. @mimowo can you please take a look?

[mimowo]

/pull-kubernetes-node-kubelet-serial-pod-disruption-conditions

[mimowo]

/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions

[k8s-ci-robot]

@mimowo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-kubelet-serial-pod-disruption-conditions	b935de6	link	false	/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mimowo]

@SergeyKanzhelev thanks for testing, after setting the expected phase to Failed in the commit the test passed.

The test was failing as the phase expected in this test is Succeeded (on master). This is after #115331, which determines the phase based on the status of the container exit codes (

kubernetes/pkg/kubelet/kubelet_pods.go

Line 1473 in 11067ce

if podIsTerminal {

). In this test a sleep container is used with exits with 0 when receiving SIGTERM. Prior to that the phase was set to Failed independently of the container exit codes in

kubernetes/pkg/kubelet/preemption/preemption.go

Line 106 in 11067ce

status.Phase = v1.PodFailed

.

These phase changes don't matter for adding of the condition so I think it is safe to continue with cherry-pick.

That being said, we have missed this scenario when reviewing the impacted scenarios (see release notes in #115331). Thus, I open an issue to discuss if the setting of phase is correct and clean up the code if it is: #118310

[mimowo]

/skip

(new tests are passing after the manual phase adjustment in https://github.com/kubernetes/kubernetes/compare/5d3f7feb709357f45adf8b890c13048911ec9fc3..b935de6df5447cbb749fb8d7e6dad0bcb01992a4)

[SergeyKanzhelev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ab21c8179a279d75d6df88f43a7369df1ec7fb92

[mimowo]

/cc kubernetes/release-managers

[Verolop]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mimowo, Verolop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [dchen1107]
• test/e2e_node/OWNERS [dchen1107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment