Updating names from webhookconversion to conversionwebhook for apiserver

[cchapla]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

PR changes the names from webhook conversion to conversion webhook to follow right naming convention.
This PR also changes the variable increment location to reflect correct log messages.

Which issue(s) this PR fixes:

Ref #117167

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes. This PR changes the apiserver metrics names from webhook_conversion_request_total to conversion_webhook_request_total and webhook_conversion_duration_seconds to conversion_webhook_duration_seconds

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @cchapla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shyamjvs]

/ok-to-test
/priority important-soon

[shyamjvs]

This PR changes the apiserver metrics names from webhook_conversion_request_total to conversion_webhook_request_total and webhook_conversion_duration_seconds to conversion_webhook_duration_seconds

To clarify, this metric was just added in a PR that was merged yesterday - #118292. It hasn't gone into a release yet - so there's no user-facing breakage.

@cchapla to avoid duplicate release notes from showing, can you clear the release note from this CR and only update there with the right metric names?

[jiahuif]

/cc @logicalhan
/assign @alexzielenski

[jiahuif]

/triage accepted

[shyamjvs]

/lgtm

Will wait for @logicalhan to give approve from sig-instrumentation side.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c3fb859337b90003de27800c988dd0f3e6372b2e

[shyamjvs]

@alexzielenski @logicalhan - can one of you provide the approval?

[alexzielenski]

Unfortunately do not have permissions

/cc @deads2k

[dims]

/assign @logicalhan

@alexzielenski @logicalhan if you cast your /approve I can find folks who have permissions

[alexzielenski]

LGTM from a "this is a mechanical renaming" standpoint. I have not looked into the wider context of this issue, though.

This does rename a metric, so would still defer to @logicalhan for approval since he has wide context on that front

[logicalhan]

/lgtm
/approve

[dims]

sig-instrumentation folks are ok, so i am happy to land this metrics change (as mentioned above, this one has not made it into a release, so we are good!)

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cchapla, dims, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment