Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112029: Fix the wrong status returned from RunPreFilterPlugins #118618

Merged
merged 1 commit into from Jul 7, 2023
Merged

Automated cherry pick of #112029: Fix the wrong status returned from RunPreFilterPlugins #118618

merged 1 commit into from Jul 7, 2023

Conversation

ingvagabund
Copy link
Contributor

@ingvagabund ingvagabund commented Jun 12, 2023 •
edited

Cherry pick of #112029 on release-1.25.

#112029: Fix the wrong status returned from RunPreFilterPlugins

For details on the cherry pick process, see the cherry pick requests page.

None

@chendave @ingvagabund
Fix the wrong status returned from RunPreFilterPlugins
d949acc 
event msg will be impacted due to the wrong status is returned.
e.g.

Warning  FailedScheduling ... running PreFilter plugin "PodTopologySpread": %!!(MISSING)w(<nil>)

Signed-off-by: Dave Chen <dave.chen@arm.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 12, 2023
@ingvagabund ingvagabund added the kind/bug Categorizes issue or PR as related to a bug. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2023
SataQiu
SataQiu reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3205c2ef845fa674da1763a08496e2bfbfad1c7

@SataQiu
Copy link
Member

SataQiu commented Jun 13, 2023

Shall we also cherry-pick this for v1.24? The end of life for v1.24 is 2023-07-28. @sanposhiho @ahg-g

@ahg-g
Copy link
Member

ahg-g commented Jun 13, 2023

no more releases for 1.24, so we can't cherrypick

@ahg-g
Copy link
Member

ahg-g commented Jun 20, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@SataQiu
Copy link
Member

SataQiu commented Jun 25, 2023

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 25, 2023 13:18
Verolop
Verolop reviewed Jul 6, 2023
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9347e55 into kubernetes:release-1.25 Jul 7, 2023
15 checks passed
@ingvagabund ingvagabund deleted the automated-cherry-pick-of-#112029-upstream-release-1.25 branch July 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop left review comments

@SataQiu SataQiu SataQiu left review comments

@denkensk denkensk Awaiting requested review from denkensk

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@Verolop Verolop

@SataQiu SataQiu

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ingvagabund @k8s-ci-robot @SataQiu @ahg-g @Verolop @chendave