Match on cri-o socket suffix only

[dgl]

This deals with the case that a user can configure cri-o to use /run/crio/crio.sock and get very confusing behavior.

See cri-o/cri-o#7010 (comment)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Updates the path used by the kubelet to decide whether the runtime is CRI-O to also match on /run/crio/crio.sock. This fixes a strange, non-obvious behaviour users may see if they configure a different (but valid) path to CRI-O. See cri-o/cri-o#7010 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update the CRI-O socket path, so users who configure kubelet to use a location like `/run/crio/crio.sock` don't see strange behaviour from CRI stats provider.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @dgl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dgl]

/sig node

[dgl]

/assign @haircommander

[haircommander]

this makes sense to me! I think the ultimate aim is to have cri stats provider not be so strange in cri-o, but that needs work that hopefully will happen over this release. in the meantime, this exact path match is really awkward and has always been a sore spot for me.

/lgtm
/ok-to-test
/priority important-soon
/triage accepted

[haircommander]

 pkg/kubelet/cadvisor/helpers_linux.go:40:26: undefined: CrioSocket
pkg/kubelet/cadvisor/util.go:74:9: undefined: strings 

some compile errors
/lgtm cancel

[bart0sh]

/retest

[dgl]

/retest

[dgl]

/retest

[dgl]

/retest

[dgl]

@haircommander sorry about the delay on this, was on leave, now ready for review (and apparently goimports wasn't setup properly, I've now fixed my setup...)

[haircommander]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: cb69a24a8d2da5f515135bc327d5f295db43f527

[kannon92]

/assign @mrunalp

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgl, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment