Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubectl: Improve conditionFuncFor expression parsing for wait --for jsonpath #118748

Merged
merged 1 commit into from Aug 15, 2023
Merged

Kubectl: Improve conditionFuncFor expression parsing for wait --for jsonpath #118748

merged 1 commit into from Aug 15, 2023

Conversation

andreaskaris
Copy link
Contributor

@andreaskaris andreaskaris commented Jun 20, 2023 •
edited

Make it possible to parse jsonpath filter expressions: Split jsonpath expressions on single '=' only and leave '==' as part of the string.

Reported-at: kubernetes/kubectl#1224

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR improves handling of the jsonpath expression in wait --for.

Which issue(s) this PR fixes:

Fixes: kubernetes/kubectl#1448

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow parsing a wider range of jsonpath expressions in kubectl wait --for.

Improved handling of jsonpath expressions for kubectl wait --for. It is now possible to use simple filter expressions which match on a field's content.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @andreaskaris. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 20, 2023
@andreaskaris
Copy link
Contributor Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added area/kubectl release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2023
@andreaskaris andreaskaris changed the title Improve conditionFuncFor expression parsing for wait --for jsonpath Kubectl: Improvents to wait --for Jun 21, 2023
@andreaskaris andreaskaris changed the title Kubectl: Improvents to wait --for Kubectl: Improvements to wait --for Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2023
@andreaskaris
Copy link
Contributor Author

@ardaguclu can you /ok-to-test?
Thanks!

@ardaguclu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2023
@andreaskaris andreaskaris mentioned this pull request Jul 10, 2023
Closed
@andreaskaris
Copy link
Contributor Author

/retest

@andreaskaris andreaskaris changed the title Kubectl: Improvements to wait --for Kubectl: Improve conditionFuncFor expression parsing for wait --for jsonpath Jul 10, 2023
@andreaskaris andreaskaris mentioned this pull request Jul 20, 2023
Closed
@andreaskaris
Improve conditionFuncFor expression parsing for wait --for jsonpath
4188998 
Make it possible to parse jsonpath filter expressions: Split
jsonpath expressions on single '=' only and leave '==' as part of the
string.

Reported-at: https://github.com/kubernetes/kubernetes/issues/119206
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@eddiezane
Copy link
Member

/cc @mpuckett159

@brianpursley
Copy link
Member

/lgtm
/approve
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d1bc771e04dc03b5c8c5a526ea96ff0940dd7a1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, brianpursley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@jmulcahyTSC
Copy link

i'm running into this issue and looking forward to this PR merging

@andreaskaris
Copy link
Contributor Author

If I understand this correctly, then K8s is currently in code freeze, so it should merge after that hopefully

@k8s-ci-robot k8s-ci-robot merged commit d486180 into kubernetes:master Aug 15, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@soltysh soltysh Awaiting requested review from soltysh

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

Assignees

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

kubectl wait-for cannot handle JSON path filter expressions like ?(@.x==y)
6 participants
@andreaskaris @k8s-ci-robot @ardaguclu @eddiezane @brianpursley @jmulcahyTSC