Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #118460: Make etcd component status consistent with health probes #119038

Merged
merged 1 commit into from Jul 7, 2023
Merged

Automated cherry pick of #118460: Make etcd component status consistent with health probes #119038

merged 1 commit into from Jul 7, 2023

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Jul 3, 2023 •
edited

Cherry pick of #118460 on release-1.26.

#118460: Make etcd component status consistent with health probes

For details on the cherry pick process, see the cherry pick requests page.

Fix component status calling etcd health endpoint over http which exposed kubernetes to the risk of complete watch starvation and is inconsistent with other etcd probing done by kube-apiserver.

@serathius @aojea
Make etcd component status consistent with health probes
1703a30 
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2023
@serathius
Copy link
Contributor Author

/assign @wojtek-t

@serathius
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 3, 2023
@serathius serathius mentioned this pull request Jul 3, 2023
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Jul 3, 2023

/lgtm
/approve

@kubernetes/release-managers @cpanato - for cherrypick approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9b8277eaf5ad28d0db4503651676b858e42ba68b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@serathius
Copy link
Contributor Author

Not sure about dependency failure as this PR doesn't touch them.

/retest

@cpanato
Copy link
Member

cpanato commented Jul 5, 2023

/test pull-kubernetes-dependencies

@Verolop
Copy link

Verolop commented Jul 6, 2023

it's been flaky, let's give it one more try (if it fails again, I'll investigate)

/test pull-kubernetes-dependencies

@jiahuif
Copy link
Member

jiahuif commented Jul 6, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 6, 2023
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 728dfdf into kubernetes:release-1.26 Jul 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serathius @wojtek-t @k8s-ci-robot @cpanato @Verolop @jiahuif