Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #118150 origin release 1.27 #119086

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Automated cherry pick of #118150 origin release 1.27 #119086

merged 2 commits into from
Jul 5, 2023

Conversation

neolit123
Copy link
Member

Cherry pick of #118150 on release-1.27.

#118150: kubeadm: remove function pointer comparison in phase test

For details on the cherry pick process, see the cherry pick requests page.

NONE

@neolit123
kubeadm: remove function pointer comparison in phase test
33af2a4 
TestBindToCommandArgRequirements has a .Pointer()
comparison that is not guaranteed to pass given
the reflected functions are closures.

This test is consistently failing on Go 1.21 rc1.
Remove said comparison from the test.
@neolit123
call ./hack/update-vendor.sh
39a4cd1
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/code-generation do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/dependency Issues or PRs related to dependency changes needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and a team July 5, 2023 05:21
@k8s-ci-robot k8s-ci-robot added area/kubectl needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 5, 2023
@neolit123 neolit123 mentioned this pull request Jul 5, 2023
Closed
@pacoxu
Copy link
Member

pacoxu commented Jul 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 927b2aa4b81545d71c59cd0861affa756673cedf

@ardaguclu ardaguclu mentioned this pull request Jul 5, 2023
Merged
@ardaguclu
Copy link
Member

/lgtm

SataQiu
SataQiu reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dims
Copy link
Member

dims commented Jul 5, 2023

/approve
/lgtm

@ardaguclu
Copy link
Member

/cc @liggitt
this one fixes go.sum errors for 1.27

@k8s-ci-robot k8s-ci-robot requested a review from liggitt July 5, 2023 13:39
@liggitt
Copy link
Member

liggitt commented Jul 5, 2023

/lgtm
/approve

still unsure why this dependency keeps causing us trouble, but the bump is a no-op so lgtm as a quick resolution

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@liggitt liggitt added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 5, 2023
@liggitt liggitt mentioned this pull request Jul 5, 2023
Merged
@liggitt
Copy link
Member

liggitt commented Jul 5, 2023

cc @kubernetes/release-managers for cherrypick merge (the 1.24-1.26 PRs are merged already)

@alculquicondor
Copy link
Member

/priority critical-urgent

we have some pending backports that are blocked on this

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, neolit123, SataQiu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 5, 2023
@champtar

This comment was marked as resolved.

Sign in to view
@k8s-ci-robot k8s-ci-robot requested a review from a team July 5, 2023 15:30
@k8s-ci-robot k8s-ci-robot merged commit 55872a8 into kubernetes:release-1.27 Jul 5, 2023
15 checks passed
@pacoxu pacoxu mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@xmudrii xmudrii xmudrii approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

@pacoxu pacoxu

@SataQiu SataQiu

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubeadm area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@neolit123 @pacoxu @k8s-ci-robot @ardaguclu @dims @liggitt @alculquicondor @champtar @SataQiu @xmudrii