Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate /pkg/controller/disruption to structured and contextual logging #119147

Merged
merged 1 commit into from Jul 12, 2023
Merged

Migrate /pkg/controller/disruption to structured and contextual logging #119147

merged 1 commit into from Jul 12, 2023

Conversation

mengjiao-liu
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate /pkg/controller/disruption to structured and contextual logging

Continue the work of to #116021

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3077

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrated the disruption controller (within `kube-controller-manager`) to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/wg structured-logging
/area logging
/sig instrumentation

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 7, 2023
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from 0e6e166 to 434a98b Compare July 7, 2023 05:31
@mengjiao-liu
Copy link
Member Author

/test pull-kubernetes-unit

@pohly
Copy link
Contributor

pohly commented Jul 7, 2023

@mengjiao-liu : there are a few more issues from #116021 that need to be fixed (mostly broken imports, but also missing parameters). You can find them by running hack/verify-golangci-lint.sh.

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from 434a98b to 0267a1d Compare July 10, 2023 03:26
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu
Copy link
Member Author

@mengjiao-liu : there are a few more issues from #116021 that need to be fixed (mostly broken imports, but also missing parameters). You can find them by running hack/verify-golangci-lint.sh.

Ok, there was a delay the day before yesterday, and the relevant errors have been fixed.

@mengjiao-liu
Copy link
Member Author

/test pull-kubernetes-verify-strict-lint

@mengjiao-liu mengjiao-liu marked this pull request as ready for review July 10, 2023 07:37
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from 8aff1a7 to 28e3d68 Compare July 10, 2023 07:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@pohly
Copy link
Contributor

pohly commented Jul 11, 2023

/retest

@pohly
Copy link
Contributor

pohly commented Jul 11, 2023

@mengjiao-liu: needs another rebase because of logcheck.conf. This PR is next, I promise!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from dca7221 to 818d58d Compare July 11, 2023 10:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@mengjiao-liu
Copy link
Member Author

@mengjiao-liu: needs another rebase because of logcheck.conf. This PR is next, I promise!

No problem. Done.

@pohly
Copy link
Contributor

pohly commented Jul 11, 2023

k8s.io/kubernetes/test/integration/disruption is still failing.

I'm going to be offline for the next 5 or so hours, but can have a look after that.

@alexzielenski
Copy link
Contributor

/triage accepted
/cc @jiahuif @cici37

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from 818d58d to 79d80ad Compare July 12, 2023 02:09
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-controller-disruption branch from 79d80ad to 1986947 Compare July 12, 2023 03:31
pohly
pohly approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @soltysh

For approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64045a786b141fa5e4d23fb17cc58583e94ad7ff

@pohly pohly mentioned this pull request Jul 12, 2023
Merged
soltysh
soltysh approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@soltysh
Copy link
Contributor

soltysh commented Jul 12, 2023

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengjiao-liu, pohly, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 745cfa3 into kubernetes:master Jul 12, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@soltysh soltysh soltysh approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@mortent mortent Awaiting requested review from mortent

@feiskyer feiskyer Awaiting requested review from feiskyer

@hwdef hwdef Awaiting requested review from hwdef

@cici37 cici37 Awaiting requested review from cici37

@jiahuif jiahuif Awaiting requested review from jiahuif

Assignees

@pohly pohly

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mengjiao-liu @k8s-ci-robot @pohly @alexzielenski @soltysh