Stream Translator Proxy and FallbackExecutor for WebSockets #119186
Merged
+2,379
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
added
area/cloudprovider
area/kubectl
area/test
sig/architecture
seans3
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
seans3
force-pushed
the
stream-translator-proxy
branch
2 times, most recently
from
1dcb306
to
a372caa
Compare
|
/retest |
seans3
force-pushed
the
stream-translator-proxy
branch
from
a372caa
to
1785deb
Compare
seans3
force-pushed
the
stream-translator-proxy
branch
from
4e2c805
to
3ff941f
Compare
|
@seans3: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-e2e-gce ...unrelated error: |
seans3
force-pushed
the
stream-translator-proxy
branch
from
3ff941f
to
210c8aa
Compare
|
/retest ...unrelated test failure for required test |
seans3
force-pushed
the
stream-translator-proxy
branch
from
210c8aa
to
b6bb8f8
Compare
|
#119186 (comment) is my only remaining comment, lgtm otherwise |
|
is the fallback e2e running in the alpha job? |
seans3
force-pushed
the
stream-translator-proxy
branch
from
b6bb8f8
to
168998e
Compare
Fixed |
Apparently it is not running in the But it is running in the |
|
/retest ...unrelated test failure in required test. |
|
/retest ...unrelated test failure in required test |
yeah, the thing is that this test has to pass always, independent of the feature flag or not, because it has fallback |
|
/lgtm go go go |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: daff9aa59a28efad0c7d296cea96399112f9612c
|
/lgtm That's good, but we also want to exercise the server translation layer. Can we get that test to run in the alpha e2e? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, logicalhan, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@seans3: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
StreamTranslatorproxy, which forwards data from a websocket server into a SPDY client. This proxy allows incremental WebSocket communication legs. This proxy is wrapped by theTranslatingHandler, delegating to theStreamTranslatorproxy if the upgrade request isWebSockets/V5.Implements
FallbackExecutor, which first attempts a WebSocket upgrade, then fallsback to legacy SPDY.Adds
TranslateStreamCloseWebsocketRequestsfeature gate, which is off by default (WebSockets is alpha). An enabled feature gate allows theStreamTranslatorproxy to be delegated from the currentUpgradeAwareproxy forWebSockets/V5upgrade requests.Adds
KUBECTL_REMOTE_COMMAND_WEBSOCKETSenvironment variable feature gate forkubectl, which is off by default. An enabled feature gate substitutes aFallbackExecutorfor the legacySPDYExecutor.Merging this PR will complete
alphafunctionality for transitioning from SPDY to WebSocket for bi-directional streaming. When both feature gates are turned on, the communication leg fromkubectlto the API Server will use the WebSocket protocol forRemoteCommand(e.g.kubectl exec, cp, and attach) instead of SPDY.Manually tested successfully with the following commands using the
nginxpod:$ ./kubectl exec nginx -- date(basic command with STDOUT)$ echo "this is a test" | ./kubectl exec -i nginx -- cat(pipe STDIN to command running on container)$ ./kubectl cp ~/deploy-1.yaml nginx:/(cp file from local to container)$ ./kubectl cp nginx:/product_name /tmp/product_name(cp file from container to local)$ ./kubectl exec -it nginx -- bash(interactive terminal)Example stress test for WebSocket client running through the
StreamTranslatorproxy testing STDIN and STDOUT streams/kind feature
Fixes: #89163