Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade prometheus common to v0.44.0 #119312

Merged
merged 2 commits into from Jul 17, 2023
Merged

upgrade prometheus common to v0.44.0 #119312

merged 2 commits into from Jul 17, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jul 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/code-generation needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/dependency Issues or PRs related to dependency changes area/kube-proxy needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, bowei and a team July 14, 2023 03:06
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Jul 14, 2023 •
edited

/test pull-kubernetes-unit



k8s.io/kubernetes/vendor/k8s.io/component-base/metrics: testutil expand_less | 0s
-- | --
{Failed;Failed;  === RUN   TestGetHistogramVecFromGatherer/filter_with_one_label     --- FAIL: TestGetHistogramVecFromGatherer/filter_with_one_label (0.00s) panic: cannot handle unexported field at {testutil.HistogramVec}[0].Histogram.state: 	"k8s.io/kubernetes/vendor/github.com/prometheus/client_model/go".Histogram consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported [recovered] 	panic: cannot handle unexported field at {testutil.HistogramVec}[0].Histogram.state: 	"k8s.io/kubernetes/vendor/github.com/prometheus/client_model/go".Histogram consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported  goroutine 76 [running]: testing.tRunner.func1.2({0xad28e0, 0xc0001e3210}) 	/usr/local/go/src/testing/testing.go:1526 +0x372 testing.tRunner.func1() 	/usr/local/go/src/testing/testing.go:1529 +0x650 panic({0xad28e0, 0xc0001e3210}) 	/usr/local/go/src/runtime/panic.go:890 +0x263 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.validator.apply({{}}, 0xc000186c80, {0xb37f20?, 0xc0001f4000?, 0xc52c00?}, {0xb37f20?, 0xc0001f47e0?, 0xb37f20?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/options.go:246 +0x445 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).tryOptions(0xc000186c80, {0xc5b348, 0xb37f20}, {0xb37f20?, 0xc0001f4000?, 0x0?}, {0xb37f20?, 0xc0001f47e0?, 0x0?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:304 +0x146 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53ef0, 0xc000188300?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:259 +0x6e9 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareStruct(0xc000186c80, {0xc5b348, 0xb67560}, {0xb67560?, 0xc0001f4000?, 0x0?}, {0xb67560?, 0xc0001f47e0?, 0x0?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:412 +0xa52 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53e60, 0xc000093e00?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:287 +0x1552 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).comparePtr(0xc000186c80, {0xc5b348, 0xb5d3a0}, {0xb5d3a0?, 0xc0000143e0?, 0x0?}, {0xb5d3a0?, 0xc000014420?, 0x0?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:564 +0x785 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53ef0, 0xc000188200?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:293 +0x1392 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareStruct(0xc000186c80, {0xc5b348, 0xb61220}, {0xb61220?, 0xc0000143e0?, 0x0?}, {0xb61220?, 0xc000014420?, 0x0?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:412 +0xa52 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53e60, 0xc000093d80?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:287 +0x1552 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).comparePtr(0xc000186c80, {0xc5b348, 0xb60ce0}, {0xb60ce0?, 0xc0001e2ea0?, 0xc000093d40?}, {0xb60ce0?, 0xc0001e3130?, 0xa50a87?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:564 +0x785 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53ec0, 0xc000024c00?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:293 +0x1392 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).statelessCompare(0xc000186c80, {0xc53ec0, 0xc000024c00}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:230 +0xe5 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareSlice.func2(0x0, 0x0) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:478 +0xed k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/internal/diff.Difference(0x2, 0x2, 0xc0000ab9f0) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/internal/diff/diff.go:244 +0xa56 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareSlice(0xc000186c80, {0xc5b348, 0xb1b700}, {0xb1b700?, 0xc0000137e8?, 0xb7c068?}, {0xb1b700?, 0xc000013800?, 0xc0000abbd0?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:477 +0xd6b k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.(*state).compareAny(0xc000186c80, {0xc53ad0, 0xc000093d00?}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:289 +0x13e5 k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp.Diff({0xb1b700, 0xc0000137e8}, {0xb1b700, 0xc000013800}, {0x0, 0x0, 0x0}) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/google/go-cmp/cmp/compare.go:120 +0xd5 k8s.io/kubernetes/vendor/k8s.io/component-base/metrics/testutil.TestGetHistogramVecFromGatherer.func1(0xc0001f09c0) 	/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/component-base/metrics/testutil/metrics_test.go:587 +0x865 testing.tRunner(0xc0001f09c0, 0xc0001e2eb0) 	/usr/local/go/src/testing/testing.go:1576 +0x217 created by testing.(*T).Run 	/usr/local/go/src/testing/testing.go:1629 +0x806 ;=== RUN   TestGetHistogramVecFromGatherer --- FAIL: TestGetHistogramVecFromGatherer (0.00s) ;}

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Jul 15, 2023

/retest

@pacoxu
Copy link
Member Author

pacoxu commented Jul 15, 2023

/cc @dims @liggitt

@liggitt
Copy link
Member

liggitt commented Jul 17, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 818521e7adde850836dd4ab4110c1fbfb6156cda

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit d627c4b into kubernetes:master Jul 17, 2023
16 checks passed
SIG Node PR Triage automation moved this from Triage to Done Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 17, 2023
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2023
@pacoxu pacoxu mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@bowei bowei Awaiting requested review from bowei

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacoxu @liggitt @k8s-ci-robot @alexzielenski