Automated cherry pick of #117804: Refactor FindAttachablePluginBySpec out of CSI code path #119363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconstructVolume() is called when kubelet may not have connection to the API server yet, therefore it cannot get CSIDriver instances to figure out if a CSI volume is attachable or not. Refactor reconstructVolume(), so it does not need FindAttachablePluginBySpec for CSI volumes, because all of them are deviceMountable (i.e. FindDeviceMountablePluginBySpec always returns the CSI volume plugin).
During CSI volume reconstruction it's not possible to tell, if the volume is attachable or not - CSIDriver instance may not be available, because kubelet may not have connection to the API server at that time. Adding uncertain state during reconstruction + adding a correct state when the API server is available.
node.status.volumesInUse should report only attachable volumes, therefore it needs to wait for the reconciler to update uncertain attachability of volumes from the API server.
To volumesNeedUpdateFromNodeStatus - because both devicePath and uncertain attach-ability needs to be fixed from node status.
to be in sync with volumesNeedUpdateFromNodeStatus.
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
area/kubelet
sig/node
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2e335215fff357fd52f723a2cde145567471c510
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
xmudrii
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #117804 on release-1.27.
#117804: Refactor FindAttachablePluginBySpec out of CSI code path
For details on the cherry pick process, see the cherry pick requests page.
Related to #117745 - picking the fix to 1.27.
This PR fixes behavior of
NewVolumeManagerReconstructionfeature, which is still off-by-default in 1.27. In theory, it should be a very harmless cherry pick. It allows us to testNewVolumeManagerReconstructionin 1.27 and potentially enable it back by default in a future 1.27 patch release.Regression test for #117745 on master branch looks green today (Jul 17th): https://testgrid.k8s.io/sig-storage-kubernetes#kind-disruptive