Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unregistered event code #119539

Merged
merged 1 commit into from
Dec 13, 2023
Merged

remove unregistered event code #119539

merged 1 commit into from
Dec 13, 2023

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We didn't register the delete event, this code will not work

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2023
@HirazawaUi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2023
@HirazawaUi
Copy link
Contributor Author

/retest

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jul 24, 2023
@HirazawaUi
Copy link
Contributor Author

/retest

1 similar comment
@HirazawaUi
Copy link
Contributor Author

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Jul 25, 2023

/triage accepted
/priority important-longterm
/assign @pohly

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 25, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 25, 2023
wackxu
wackxu reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@wackxu wackxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a5849d02e0be8403d2a6597a49bce598d630eb4

pohly
pohly suggested changes Aug 1, 2023
View reviewed changes
pkg/scheduler/framework/plugins/dynamicresources/dynamicresources.go
if newObj == nil {
// Deletes don't make a pod schedulable.
return framework.QueueSkip
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is probably never reached, but I am on the edge whether the check should be removed outright.

If we never expect this to happen, should an error be logged when it occurs? Should the code panic?

If the check gets removed for performance reasons, then at least add a comment to the function that explains that newObj will never be nil and why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this will never happen, if an error occurs because of the removal of this code, then there is a problem with the code elsewhere and the problem should be exposed, not skip here, what do you think.

And i agree with adding a comment explains that newObj will never be nil and why

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's replace with a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the comment, please review

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2023
@HirazawaUi HirazawaUi force-pushed the remove-not-register-event-code branch from 4bdfb02 to 986d205 Compare August 4, 2023 17:05
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2023
pohly
pohly approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dac0e68a4ab2bd9aad001aa94a42046ad347b202

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2023
@HirazawaUi HirazawaUi force-pushed the remove-not-register-event-code branch from 986d205 to b20bc79 Compare October 7, 2023 13:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2023
pacoxu
pacoxu reviewed Oct 17, 2023
View reviewed changes
pkg/scheduler/framework/plugins/dynamicresources/dynamicresources.go
@@ -302,16 +302,11 @@ func (pl *dynamicResources) PreEnqueue(ctx context.Context, pod *v1.Pod) (status
return nil
}

// isSchedulableAfterClaimChange is invoked for all claim events reported by
// isSchedulableAfterClaimChange is invoked for add and update claim events reported by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to add

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it should be 'for', we call isSchedulableAfterClaimChange when we receive the add and update event.

@pacoxu
Copy link
Member

pacoxu commented Oct 17, 2023

/remove-sig node
only dra related code is owned by sig node here.

@k8s-ci-robot k8s-ci-robot removed the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 17, 2023
@pacoxu pacoxu moved this from Needs Approver to Done in SIG Node PR Triage Oct 17, 2023
@HirazawaUi
Copy link
Contributor Author

/assign @sanposhiho
May you take a look at this PR?

sanposhiho
sanposhiho approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 680362cc2e8d54b7eadc50214222ef06b3d72437

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, pohly, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74afd1a into kubernetes:master Dec 13, 2023
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@sanposhiho sanposhiho sanposhiho approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@wackxu wackxu Awaiting requested review from wackxu

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

@wackxu wackxu

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Scheduling
Archived in project
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@HirazawaUi @bart0sh @k8s-ci-robot @pacoxu @pohly @wackxu @sanposhiho