Automated cherry pick of #117710: e2e_node: move getSampleDevicePluginPod to #119621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image_list.go is one of the files included in the non-test variant Go build list, but its getSampleDevicePluginPod function references readDaemonSetV1OrDie function defined in device_plugin_test.go which is included in the test variant Go build list only. (The file name is *_test.go). As a result, "go build" fails with the undefined reference error. In practice, that may not be an issue since k8s project contributors aren't meant to run go build on this package. However, tools that depend on go build to operate - e.g., gopls or govulncheck ./... - will report this as an error. Fix this error and make test/e2e package pass go build by moving this file to also test-only source code.
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
area/test
sig/node
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
/retest |
|
/priority-backlog |
k8s-ci-robot
added
release-note-none
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c790ef543b0c3326a5a6b92d638752f3f37a2d23
|
xmudrii
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
|
/test pull-kubernetes-node-e2e-containerd |
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
1 similar comment
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
liggitt
deleted the
automated-cherry-pick-of-#117710-upstream-release-1.26
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #117710 on release-1.26.
#117710: e2e_node: move getSampleDevicePluginPod to
For details on the cherry pick process, see the cherry pick requests page.