New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #117710: e2e_node: move getSampleDevicePluginPod to #119622
Automated cherry pick of #117710: e2e_node: move getSampleDevicePluginPod to #119622
Conversation
image_list.go is one of the files included in the non-test variant Go build list, but its getSampleDevicePluginPod function references readDaemonSetV1OrDie function defined in device_plugin_test.go which is included in the test variant Go build list only. (The file name is *_test.go). As a result, "go build" fails with the undefined reference error. In practice, that may not be an issue since k8s project contributors aren't meant to run go build on this package. However, tools that depend on go build to operate - e.g., gopls or govulncheck ./... - will report this as an error. Fix this error and make test/e2e package pass go build by moving this file to also test-only source code.
9146cc5
to
0f8a4fd
Compare
/triage accepted |
/kind cleanup |
/priority backlog |
LGTM label has been added. Git tree hash: 3a5551feaaa0d7b2cd60ede1feaae55346147247
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RelEng:
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-kubernetes-e2e-kind-ipv6 |
Cherry pick of #117710 on release-1.25.
#117710: e2e_node: move getSampleDevicePluginPod to
For details on the cherry pick process, see the cherry pick requests page.