Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #119835: Avoid returning nil responseKind in v1beta1 aggregated #119871

Merged
merged 1 commit into from Aug 10, 2023
Merged

Automated cherry pick of #119835: Avoid returning nil responseKind in v1beta1 aggregated #119871

merged 1 commit into from Aug 10, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 9, 2023

Cherry pick of #119835 on release-1.26.

#119835: Avoid returning nil responseKind in v1beta1 aggregated

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver labels Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2023
@liggitt liggitt force-pushed the automated-cherry-pick-of-#119835-upstream-release-1.26 branch from 1c6fc64 to 739d4c2 Compare August 9, 2023 19:06
@liggitt liggitt force-pushed the automated-cherry-pick-of-#119835-upstream-release-1.26 branch from 739d4c2 to fc529b6 Compare August 9, 2023 19:25
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2023

/retest

@jpbetz
Copy link
Contributor

jpbetz commented Aug 9, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3d3b7cce51d3186c5bb541c9eba5baa3d0744780

@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2023

cc @kubernetes/release-managers

This is a late-breaking addition to 1.28.0 (#119835) resolving a regression in 1.27 and fixing a client issue related to it. It would be ideal to include this in the current patch releases if possible.

@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 81c519f into kubernetes:release-1.26 Aug 10, 2023
16 checks passed
@liggitt liggitt deleted the automated-cherry-pick-of-#119835-upstream-release-1.26 branch August 10, 2023 15:27
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @jpbetz @k8s-ci-robot @alexzielenski @jeremyrickard