-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job: Replace deprecated workqueue function with supported one #119904
Job: Replace deprecated workqueue function with supported one #119904
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mimowo |
/hold for code freeze term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alculquicondor
I would just suggest replacing "library" with "function" in the title
LGTM label has been added. Git tree hash: 5dd6b316fbdaea6cd279ed77938ca2e456f37f4c
|
SGTM /retitle Job: Replace deprecated workqueue function with supported one |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In Job, I replaced the deprecated workqueue library with the supported one:
Deprecated:
NewRateLimitingQueueWithDelayingInterface
kubernetes/staging/src/k8s.io/client-go/util/workqueue/rate_limiting_queue.go
Lines 92 to 99 in 6e0cb24
New:
NewRateLimitingQueueWithConfig
kubernetes/staging/src/k8s.io/client-go/util/workqueue/rate_limiting_queue.go
Lines 62 to 82 in 6e0cb24
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: