Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links to testgrid dashboard #119934

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix broken links to testgrid dashboard #119934

merged 2 commits into from
Sep 7, 2023

Conversation

letmerecall
Copy link
Contributor

@letmerecall letmerecall commented Aug 14, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixes a bunch of broken link to testgrid dashboard

Which issue(s) this PR fixes:

This is related to an umbrella issue and fixes a task of the same:
kubernetes/test-infra#30370

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Related issues:

kubernetes/test-infra#30370
kubernetes/sig-release#2304

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 04:35:10 UTC 2023.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @letmerecall!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @letmerecall. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 14, 2023
@letmerecall letmerecall mentioned this pull request Aug 14, 2023
Closed
40 tasks
@letmerecall letmerecall changed the title Fix broken link to testgrid Fix broken links to testgrid dashboard Aug 14, 2023
@letmerecall
Copy link
Contributor Author

cc: @rjsadow

rashansmith
rashansmith reviewed Aug 17, 2023
View reviewed changes
CHANGELOG/CHANGELOG-1.4.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@letmerecall for the url: https://testgrid.k8s.io/docker the website message reads "Unknown dashboard "docker". Select a dashboard.". Is that expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super sure (I think it's expected).
This changelog is from 1.4 & there is no dashboard name 'docker' as of now, so the possibility is that it doesn't exist anymore.

Screenshot 2023-08-17 at 10 42 03 PM

Any idea who might know about this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we typically update the CHANGELOGs. I would recommend reverting any updates made to them but keeping the MAINTAINERS update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks :)

@rjsadow
Copy link
Contributor

rjsadow commented Aug 17, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c4502e56c297d70219bb5ccb69580084eaba7e4

@rjsadow
Copy link
Contributor

rjsadow commented Aug 17, 2023

/retest

@letmerecall
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@letmerecall
Copy link
Contributor Author

/assign @KnVerey

@chenliyo99
Copy link

/assign

@letmerecall
Copy link
Contributor Author

letmerecall commented Aug 26, 2023 •
edited

/cc @wojtek-t . Could you help me approve these changes?

@letmerecall letmerecall mentioned this pull request Sep 3, 2023
Closed
@letmerecall
Copy link
Contributor Author

letmerecall commented Sep 7, 2023 •
edited

/cc @dims

Would appreciate it if you could help (or direct towards) approving this one.

@dims
Copy link
Member

dims commented Sep 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, letmerecall, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@letmerecall
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit c1628f3 into kubernetes:master Sep 7, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsadow rjsadow rjsadow approved these changes

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@rashansmith rashansmith Awaiting requested review from rashansmith

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dims dims Awaiting requested review from dims

Assignees

@KnVerey KnVerey

@chenliyo99 chenliyo99

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@letmerecall @k8s-ci-robot @rjsadow @chenliyo99 @dims @rashansmith @KnVerey