Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #119761: Statefulset should wait for new replicas when removing #119970

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Automated cherry pick of #119761: Statefulset should wait for new replicas when removing #119970

merged 2 commits into from
Sep 6, 2023

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Aug 16, 2023 •
edited by liggitt

Cherry pick of #119761 on release-1.28.

#119761: Statefulset should wait for new replicas when removing

For details on the cherry pick process, see the cherry pick requests page.

NONE

@soltysh
Statefulset should wait for new replicas when removing .start.ordinal
58ac6e1
@soltysh
Drop [Feature: tag to make sure this tests runs on pre-submits
20b69ae 
In v1.27 StatefulSetStartOrdinal became beta, which makes it on by
default, but we forgot to turn these tests on along with it. This makes
these tests run always.
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2023
@soltysh
Copy link
Contributor Author

soltysh commented Aug 16, 2023

/kind flake
/sig apps
/sig testing

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 16, 2023
@soltysh
Copy link
Contributor Author

soltysh commented Aug 16, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 16, 2023
bertinatto
bertinatto reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This fixed a flake in our CI.

@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8865d2938380503cad55c296cf8b7d4eaae94c10

@soltysh
Copy link
Contributor Author

soltysh commented Aug 16, 2023

@kubernetes/release-managers this feature is beta since 1.27, but the tests were not run until #119761 to make sure we don't regress and also to fix already identified problems this PR has two fixes:

  1. drops Feature:... tag to ensure it's being run in pre-submits
  2. fixes problems identified in CI.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 1, 2023
@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/test pull-kubernetes-e2e-gce

@soltysh
Copy link
Contributor Author

soltysh commented Sep 6, 2023

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit f47aa12 into kubernetes:release-1.28 Sep 6, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Sep 6, 2023
@soltysh soltysh deleted the automated-cherry-pick-of-#119761-upstream-release-1.28 branch September 6, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@mortent mortent Awaiting requested review from mortent

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soltysh @k8s-ci-robot @saschagrunert @bertinatto