Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for extract tag functions in prereleaselifecyclegenerators #120050

Merged
merged 1 commit into from Sep 29, 2023

Conversation

DamianSawicki
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds unit tests for extractTag, extractEnabledTypeTag, and extractReplacementTag from the file code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go as requested in issue #119289.

Which issue(s) this PR fixes:

Fixes #119289

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @DamianSawicki!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @DamianSawicki. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 18, 2023
@aojea
Copy link
Member

aojea commented Aug 21, 2023

/ok-to-test
/assign @rikatz

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2023
@DamianSawicki DamianSawicki force-pushed the some-tests branch 2 times, most recently from 048bec3 to ef54314 Compare August 21, 2023 15:19
@DamianSawicki DamianSawicki marked this pull request as ready for review August 21, 2023 15:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@DamianSawicki
Copy link
Contributor Author

/retest

@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2023
@aojea
Copy link
Member

aojea commented Aug 28, 2023

/assign @sttts

as owner

approvers:
  - deads2k
  - wojtek-t
  - sttts

@rikatz
Copy link
Contributor

rikatz commented Aug 28, 2023

Overall this is great and lgtm!!

If you want to copy a test for isApiType feel free to copy from here.

Once this gets merged I will also crossport back to kubepug :) Thanks for helping on increasing the coverage test!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02cbcc9133163ea63311f754341547bea47aee62

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@DamianSawicki
Copy link
Contributor Author

If you want to copy a test for isApiType feel free to copy from here.

Thanks for pointing it out, copied!

Once this gets merged I will also crossport back to kubepug :) Thanks for helping on increasing the coverage test! /lgtm

I'm very glad I could help a bit :)

@DamianSawicki
Copy link
Contributor Author

/retest

@DamianSawicki
Copy link
Contributor Author

@rikatz your lgtm disappeared when I pushed Test_isAPIType. Could you please have a look again and lgtm?

@aojea
Copy link
Member

aojea commented Sep 11, 2023

/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4064f7a2f1273d2106a9d22b70ed472f4732a8c6

@DamianSawicki
Copy link
Contributor Author

Hey @thockin, could you please move it forward?

@DamianSawicki
Copy link
Contributor Author

Ping @thockin.

@sttts
Copy link
Contributor

sttts commented Sep 28, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023
@DamianSawicki
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 46dea30 into kubernetes:master Sep 29, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage on code generator
8 participants