Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-node: fix TopologyManager test jobs. #120349

Merged
merged 1 commit into from
Sep 13, 2023
Merged

e2e-node: fix TopologyManager test jobs. #120349

merged 1 commit into from
Sep 13, 2023

Conversation

ruquanzhao
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Change label NodeFeature:TopologyManager to Feature:TopologyManager so prow jobs can run these tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

related to kubernetes/test-infra#30544

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

e2e-node: fix TopologyManager test jobs.
bfc3c21 
Signed-off-by: Ruquan Zhao <ruquan.zhao@arm.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2023
@ruquanzhao
Copy link
Member Author

as @bart0sh mentioned(kubernetes/test-infra#30544 (comment)), we should use [Feature:TopologyManager] instead of adding more [NodeFeature:] in codes.

@ruquanzhao
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

swatisehgal
swatisehgal approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4e67ab6f4ee102da8ed5a07c86475e449847471

@swatisehgal
Copy link
Contributor

/assign @SergeyKanzhelev
for approval

@swatisehgal
Copy link
Contributor

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Sep 2, 2023
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Sep 2, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Issues - To do in SIG Node CI/Test Board Sep 6, 2023
@ffromani
Copy link
Contributor

/test pull-kubernetes-node-kubelet-serial-cpu-manager

one last try now that the job should be fixed

@ffromani
Copy link
Contributor

/lgtm

I somehow remember we wanted to deprecate NodeFeature in favor of Feature but I'm not sure about the direction of the deprecation. It seems to me the direction is correct here, so LGTM

@ffromani ffromani moved this from Issues - To do to PRs - Needs Approver in SIG Node CI/Test Board Sep 12, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruquanzhao, SergeyKanzhelev, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board Sep 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 04e5914 into kubernetes:master Sep 13, 2023
16 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 13, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 18, 2023

After this is triggered in some CI, #120725 ci-kubernetes-node-kubelet-containerd-resource-managers started to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@swatisehgal swatisehgal swatisehgal approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@SergeyKanzhelev SergeyKanzhelev

@swatisehgal swatisehgal

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ruquanzhao @k8s-ci-robot @swatisehgal @ffromani @pacoxu @SergeyKanzhelev