Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run the nodeipam controller on KCM if cloud provider external #120389

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Don't run the nodeipam controller on KCM if cloud provider external #120389

merged 1 commit into from
Sep 3, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Sep 3, 2023 •
edited 

NONE

Fixes: #120387

E0903 15:52:57.448708       9 controllermanager.go:586] "Error starting controller" err="--cidr-allocator-type is set to 'CloudAllocator' but cloud provider is not configured" controller="node-ipam-controller"
E0903 15:52:57.448717       9 controllermanager.go:240] "Error starting controllers" err="--cidr-allocator-type is set to 'CloudAllocator' but cloud provider is not configured"
Flag --volume-host-allow-local-loopback has been deprecated, This flag is currently no-op and will be deleted.

aojea
  [3 minutes ago](https://kubernetes.slack.com/archives/C718BPBQ8/p1693768087237869?thread_ts=1693739705.140789&cid=C718BPBQ8)
it tries to run the CloudAllocator ipam controller from KCM





aojea
  [3 minutes ago](https://kubernetes.slack.com/archives/C718BPBQ8/p1693768089641969?thread_ts=1693739705.140789&cid=C718BPBQ8)
and it fails


aojea
  [2 minutes ago](https://kubernetes.slack.com/archives/C718BPBQ8/p1693768103030669?thread_ts=1693739705.140789&cid=C718BPBQ8)
and the KCM runs all the other controllers to create the serviceaccount IIRC


aojea
  [2 minutes ago](https://kubernetes.slack.com/archives/C718BPBQ8/p1693768108326019?thread_ts=1693739705.140789&cid=C718BPBQ8)
so the addon manager can not progress


aojea
  [2 minutes ago](https://kubernetes.slack.com/archives/C718BPBQ8/p1693768117770889?thread_ts=1693739705.140789&cid=C718BPBQ8)
and install the corresponding roles for the other components
New

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 3, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Sep 3, 2023
@aojea
Copy link
Member Author

aojea commented Sep 3, 2023

/test pull-kubernetes-e2e-gci-gce-ingress

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 3, 2023
@k8s-ci-robot
Copy link
Contributor

@aojea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gci-gce-ingress 4626512c7ebc7e5d44a3abae86635f89725ea4dc link false /test pull-kubernetes-e2e-gci-gce-ingress

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aojea
Don't run the nodeipam controller on KCM if cloud provider external
410ac14 
Change-Id: Ic1da0e9ced2dc8d3d382fee5636bbee18b3a29f7
Signed-off-by: Antonio Ojea <aojea@google.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2023
@aojea aojea changed the title [WIP] [TEST] Revert "Added support for image credential provider for windows and a… Don't run the nodeipam controller on KCM if cloud provider external Sep 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2023
@aojea
Copy link
Member Author

aojea commented Sep 3, 2023

/test pull-kubernetes-e2e-gci-gce-ingress

@aojea
Copy link
Member Author

aojea commented Sep 3, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 3, 2023
@aojea
Copy link
Member Author

aojea commented Sep 3, 2023

/test pull-kubernetes-e2e-gce-correctness
/test pull-kubernetes-e2e-gce-serial
/test pull-kubernetes-e2e-gci-gce-ingress
/test pull-kubernetes-e2e-gce-cos-kubetest2

@aojea aojea mentioned this pull request Sep 3, 2023
Closed
@dims
Copy link
Member

dims commented Sep 3, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b10d6b2877a4731f85cdadffce01cd4d9686b0ff

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2023
@dims dims mentioned this pull request Sep 3, 2023
Closed
@k8s-ci-robot k8s-ci-robot merged commit 6fa2df0 into kubernetes:master Sep 3, 2023
14 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 3, 2023
@dims dims mentioned this pull request Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

External GCE cloud provider has trouble with kubelet(s) in worker nodes joining the control plane node
3 participants
@aojea @k8s-ci-robot @dims