Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup:e2e:stop using deprecated wait.ErrWaitTimeout #120407

Merged
merged 1 commit into from
Sep 6, 2023
Merged

cleanup:e2e:stop using deprecated wait.ErrWaitTimeout #120407

merged 1 commit into from
Sep 6, 2023

Conversation

shijinye
Copy link
Contributor

@shijinye shijinye commented Sep 4, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cleanup:e2e:stop using deprecated wait.ErrWaitTimeout

Which issue(s) this PR fixes:

Fixes #107826

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shijinye. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 4, 2023
@shijinye shijinye force-pushed the e2ecleanup-storage-errwaittimeout branch from b439143 to bc6b1b6 Compare September 4, 2023 13:45
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2023
@shijinye shijinye force-pushed the e2ecleanup-storage-errwaittimeout branch from bc6b1b6 to 9795df4 Compare September 4, 2023 13:53
@shijinye
Copy link
Contributor Author

shijinye commented Sep 5, 2023

/cc @carlory could you help to review this PR?

@alexzielenski
Copy link
Contributor

/cc @Jefftree
could you review the apimachinery changes
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2023
@Jefftree
Copy link
Member

Jefftree commented Sep 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2023
@Jefftree
Copy link
Member

Jefftree commented Sep 5, 2023

/retest
flake: #119600

@Jefftree
Copy link
Member

Jefftree commented Sep 5, 2023

Looks reasonable
/lgtm
/assign @sttts

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76f413ec6edced8c881d9eb5a3ba75089fd3007f

@shijinye
Copy link
Contributor Author

shijinye commented Sep 6, 2023

/retest

@shijinye
Copy link
Contributor Author

shijinye commented Sep 6, 2023

/test pull-kubernetes-e2e-autoscaling-hpa-cm

@sttts
Copy link
Contributor

sttts commented Sep 6, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shijinye, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@shijinye
Copy link
Contributor Author

shijinye commented Sep 6, 2023

/retest

@shijinye
Copy link
Contributor Author

shijinye commented Sep 6, 2023

/test pull-kubernetes-e2e-gce

1 similar comment
@shijinye
Copy link
Contributor Author

shijinye commented Sep 6, 2023

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit a8aa362 into kubernetes:master Sep 6, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 6, 2023
@shijinye shijinye mentioned this pull request Mar 25, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@sttts sttts

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shijinye @k8s-ci-robot @alexzielenski @Jefftree @sttts