Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bump npd to v0.8.14" #120441

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Sep 6, 2023

What type of PR is this?

This reverts commit 7b44d73 in PR #120194
/kine failing-test

What this PR does / why we need it:

The NPD v0.8.14 image seems bad, the arm64 version has an x86_64 node-problem-detector binary and its failing all arm64 tests.

https://storage.googleapis.com/k8s-triage/index.html?sig=node&job=ec2&xjob=windows#9f7f7053b14ff9d31a67

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 6, 2023
@tzneal
Copy link
Contributor Author

tzneal commented Sep 6, 2023

$ crane manifest registry.k8s.io/node-problem-detector/node-problem-detector:v0.8.14
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "manifests": [
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "digest": "sha256:98034f47cdfa331105265f025c0dbff781e8c15436f726eceacec52644a7c014",
      "size": 1488,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "digest": "sha256:38ddabcad5a96bfb4af3bf6e61348198f7da4441b08a17c9ad0ea9bdb3a8689a",
      "size": 1488,
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    }
  ]
}


$ crane manifest registry.k8s.io/node-problem-detector/node-problem-detector@sha256:38ddabcad5a96bfb4af3bf6e61348198f7da4441b08a17c9ad0ea9bdb3a8689a
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
  "config": {
    "mediaType": "application/vnd.docker.container.image.v1+json",
    "digest": "sha256:a0e50a81a0e3fb03c4012573eb3416f450af62a279a647dde1e3ccc83ca5d8b5",
    "size": 2676
  },
  "layers": [
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:f91cc52e2c97c480189bb2da87653dd9abfe2679c36fc41b9db68878827748b4",
      "size": 25322200
    },
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:86c650b37460bdd568db653fe0ea8d628fe802bb15b47c5c2879fb2fd80b1d50",
      "size": 3149001
    },
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1",
      "size": 32
    },
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:a19a5af3e67a96f03e92287598725e391cf7df49799ceb0f1abc1c88fdfb8e82",
      "size": 20213297
    },
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:f239dff246d22a7de3be61ff3679722e66982089630b0591a057d01889f0c986",
      "size": 13346251
    },
    {
      "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
      "digest": "sha256:cad51d6b0d0b6b9ac3b3f1a0051eb93e35d1b84c5e25ad2482f8b71a49e58a01",
      "size": 5852
    }
  ]
}

$ crane blob registry.k8s.io/node-problem-detector/node-problem-detector@sha256:a19a5af3e67a96f03e92287598725e391cf7df49799ceb0f1abc1c88fdfb8e82 | tar -zxv
node-problem-detector

$ file node-problem-detector
node-problem-detector: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=bd9bd59069612b94e84e1c60d73ebf61d618cd44, for GNU/Linux 3.2.0, with debug_info, not stripped

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2023
@tzneal
Copy link
Contributor Author

tzneal commented Sep 6, 2023

/cc @bzsuni

@k8s-ci-robot
Copy link
Contributor

@tzneal: GitHub didn't allow me to request PR reviews from the following users: bzsuni.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bzsuni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tzneal
Copy link
Contributor Author

tzneal commented Sep 6, 2023

/retest

@hakman
Copy link
Member

hakman commented Sep 6, 2023

Ref: kubernetes/node-problem-detector#797

/kind failing-test
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25f181283e53f142726e4868dc6c662fac025fb3

@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

/lgtm
/approve
/cc @vteratipally
/assign @dims

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Sep 6, 2023
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Sep 6, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 6, 2023

/triage accepted
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2023
@marseel
Copy link
Member

marseel commented Sep 6, 2023

/approve

@vteratipally
Copy link
Contributor

/lgtm

@liggitt
Copy link
Member

liggitt commented Sep 6, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, marseel, pacoxu, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@liggitt
Copy link
Member

liggitt commented Sep 6, 2023

As a follow up, can we remove npd from this folder? This is only for CI tests and we should be removing things from here wherever possible instead of continuing to bump them to new versions.

@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

As a follow up, can we remove npd from this folder? This is only for CI tests and we should be removing things from here wherever possible instead of continuing to bump them to new versions.

Do you mean removing the cluster/addons/node-problem-detector? The version bump is also for the CI tests.

The NPD is not been that active in recent years. Since v0.8.0 was released on Oct 31, 2019, there has been no minor release. Only some patch releases: only 2 releases a year after 2021 Sept.

@liggitt
Copy link
Member

liggitt commented Sep 6, 2023

Do you mean removing the cluster/addons/node-problem-detector? The version bump is also for the CI tests.

Yes, unless that test is exercising some aspect of code inside core kubernetes components, it shouldn't live in this dir.

@k8s-ci-robot k8s-ci-robot merged commit 56cc5e7 into kubernetes:master Sep 6, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 6, 2023
@tzneal tzneal deleted the revert-npd-update branch September 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants