-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "bump npd to v0.8.14" #120441
Revert "bump npd to v0.8.14" #120441
Conversation
This reverts commit 7b44d73.
|
/cc @bzsuni |
@tzneal: GitHub didn't allow me to request PR reviews from the following users: bzsuni. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Ref: kubernetes/node-problem-detector#797 /kind failing-test |
LGTM label has been added. Git tree hash: 25f181283e53f142726e4868dc6c662fac025fb3
|
/lgtm |
/triage accepted |
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, marseel, pacoxu, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a follow up, can we remove npd from this folder? This is only for CI tests and we should be removing things from here wherever possible instead of continuing to bump them to new versions. |
Do you mean removing the The NPD is not been that active in recent years. Since v0.8.0 was released on Oct 31, 2019, there has been no minor release. Only some patch releases: only 2 releases a year after 2021 Sept. |
Yes, unless that test is exercising some aspect of code inside core kubernetes components, it shouldn't live in this dir. |
What type of PR is this?
This reverts commit 7b44d73 in PR #120194
/kine failing-test
What this PR does / why we need it:
The NPD v0.8.14 image seems bad, the arm64 version has an x86_64 node-problem-detector binary and its failing all arm64 tests.
https://storage.googleapis.com/k8s-triage/index.html?sig=node&job=ec2&xjob=windows#9f7f7053b14ff9d31a67
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: